public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants
Date: Wed, 08 Jul 2009 17:27:38 -0500	[thread overview]
Message-ID: <4A551D5A.5060300@freescale.com> (raw)
In-Reply-To: <20090708215703.B401A832E416@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Scott Wood,
> 
> In message <4A550FAE.30500@freescale.com> you wrote:
>>> And by default we would add CONFIG_SYS_NO_64BIT_VSPRINTF to all board
>>> config files?
>> No, that's the point -- it would require the board maintainer to 
>> explicitly say "this board doesn't need this".  By default we would 
>> provide a correct printf.
> 
> But then applying this patch would break some boards that are working
> now. Shirking off responsibility and have the board  maintainers  fix
> it again is IMHO not the right thing to do.

What would break?  If things would no longer fit where they currently 
fit, that could happen on any change that increases code size -- 
possibly even just by changing compilers (this exact thing happened to 
the NAND bootstrap on some boards with very recent GCC).  That's life, 
and IMHO it is not reasonable to arbitrarily block changes that fix bugs 
because of the theoretical possibility that it might push someone's size 
over the limit.

A quick grep shows several instances of %ll/%L in other places that may 
not be obvious to the board maintainer (cmd_mmc, ubi, disk/part_efi, 
cpu/mpc8xxx/ddr, lmb, disk/part, cmd_ide, reiserfs).  Boards that use 
those without 64-bit printf are broken *right now*.

-Scott

  reply	other threads:[~2009-07-08 22:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06  9:48 [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants Stefan Roese
2009-07-06 11:17 ` Wolfgang Denk
2009-07-06 15:39   ` Stefan Roese
2009-07-08 20:01     ` Wolfgang Denk
2009-07-08 21:11       ` Scott Wood
2009-07-08 21:24         ` Wolfgang Denk
2009-07-08 21:29           ` Scott Wood
2009-07-08 21:57             ` Wolfgang Denk
2009-07-08 22:27               ` Scott Wood [this message]
2009-07-09  4:57                 ` Stefan Roese
2009-07-09  7:41                 ` Wolfgang Denk
2009-07-08 22:18         ` Jerry Van Baren
2009-07-08 22:27           ` Scott Wood
2009-07-09  5:00           ` Stefan Roese
2009-07-09 12:24             ` Jerry Van Baren
2009-07-09 12:48               ` Stefan Roese
2009-07-09 13:02                 ` Jerry Van Baren
2009-07-09  4:54       ` Stefan Roese
2009-07-17 18:44         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A551D5A.5060300@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox