From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Thu, 09 Jul 2009 09:46:56 +0200
Subject: [U-Boot] [PATCH 4/4] arm/kirkwood: Add Keymile SUEN3 support
In-Reply-To: <200907090902.29405.sr@denx.de>
References: <1247068015-16224-1-git-send-email-sr@denx.de>
	<20090708185358.0FFB2832E416@gemini.denx.de>
	<200907090902.29405.sr@denx.de>
Message-ID: <4A55A070.9040707@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Stefan,

Stefan Roese wrote:
> On Wednesday 08 July 2009 20:53:58 Wolfgang Denk wrote:
>>> diff --git a/MAKEALL b/MAKEALL
>>> index 41f1445..6c80694 100755
>>> --- a/MAKEALL
>>> +++ b/MAKEALL
[...]
>>> +#define CONFIG_EXTRA_ENV_SETTINGS					\
>>> +	"load=tftp 400000 suen3/u-boot.bin\0"				\
>>> +	"update=nand erase 0 60000;nand write 400000 0 60000\0"		\
>>> +	"upd=run load update\0"						\
>>> +	"mtdparts=orion_nand:512k(uboot),512k at 512k(env),"		\
>>> +		"2m at 1m(kernel),13m at 3m(rootfs)\0"			\
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> ..
>>
>>> +#define MTDPARTS_DEFAULT	"mtdparts=orion_nand:512k(u-boot),"	\
>>> +					"256k(env),"		\
>>> +					"2m(kernel),"		\
>>> +					"16m(rootfs),"		\
>>> +					"32m(fs),"		\
>>> +					"-(ubifs)"
>> This seems inconsistent to me. How  about  defining  MTDPARTS_DEFAULT
>> first,  and then just inserting the already defined value, so you can
>> be sure that this doesn;t happen again?
> 
> Yes, good catch. Will change. Thanks for spotting.

Maybe you have a look at:

include/configs/km8xx.h

for an example.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany