From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Thu, 09 Jul 2009 09:02:38 -0400 Subject: [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants In-Reply-To: <200907091448.14376.sr@denx.de> References: <1246873688-25113-1-git-send-email-sr@denx.de> <200907090700.19816.sr@denx.de> <4A55E191.9090402@ge.com> <200907091448.14376.sr@denx.de> Message-ID: <4A55EA6E.1030901@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: > On Thursday 09 July 2009 14:24:49 Jerry Van Baren wrote: >>> All this would increase the code size for those boards not supporting the >>> 64bit printf format. Not sure by how much, but I suggest to just fix the >>> problem by supporting this format correctly instead of adding new code to >>> print some warnings here. >>> >>> Best regards, >>> Stefan >> That is what Scott is trying to do, but fixing 64bit printf causes a >> 2K++ increase in size to the boards that don't currently support 64bit >> printf (some of which are broken due to the error). Wolfgang is >> resisting that. >> >> Adding code to print a warning and handle the varargs properly will >> probably be less than 100 bytes. It looks like this is the compromise >> Wolfgang favors. > > I doubt that this could be done in less than 100 bytes. A descriptive error > message string alone will probably be around >= 60 chars. But I know this is > nitpicking. Agreed. FWIIW, I wasn't assuming a /descriptive/ error message. I was assuming printf would simply print the format string, e.g. "%lld", rather than a possibly erroneous value. Another alternative would be to do the spreadsheet idiom and print hashes "########". > I'm still voting for adding this 2k and doing it correctly on all boards. With > the option to disable this 64bit support (as Scott suggested) on boards with > very tight resources. Me too. > Best regards, > Stefan Thanks, gvb