public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] smc911x: fix warning: large integer implicitly truncated to unsigned type
Date: Thu, 09 Jul 2009 23:28:35 -0700	[thread overview]
Message-ID: <4A56DF93.3030206@gmail.com> (raw)
In-Reply-To: <1244901305-4858-1-git-send-email-plagnioj@jcrosoft.com>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> use smc911x_reg_read/smc911x_reg_write instead of
> smc911x_get_mac_csr/smc911x_set_mac_csr
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  drivers/net/smc911x.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 455b055..0507a9a 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -119,7 +119,7 @@ static int smc911x_phy_reset(void)
>  
>  static void smc911x_shutdown(void)
>  {
> -	unsigned int cr;
> +	u32 cr;
>  
>  	/* Turn of Rx and TX */
>  	cr = smc911x_get_mac_csr(MAC_CR);
> @@ -127,13 +127,13 @@ static void smc911x_shutdown(void)
>  	smc911x_set_mac_csr(MAC_CR, cr);
>  
>  	/* Stop Transmission */
> -	cr = smc911x_get_mac_csr(TX_CFG);
> +	cr = smc911x_reg_read(TX_CFG);
>  	cr &= ~(TX_CFG_STOP_TX);
> -	smc911x_set_mac_csr(TX_CFG, cr);
> +	smc911x_reg_write(TX_CFG, cr);
>  	/* Stop receiving packets */
> -	cr = smc911x_get_mac_csr(RX_CFG);
> +	cr = smc911x_reg_read(RX_CFG);
>  	cr &= ~(RX_CFG_RXDOFF);
> -	smc911x_set_mac_csr(RX_CFG, cr);
> +	smc911x_reg_write(RX_CFG, cr);
>  
>  }
>  
>   
This patch doesn't apply (there's no function 'smc911x_shutdown()' in 
either mainline or the net tree.

regards,
Ben

      parent reply	other threads:[~2009-07-10  6:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08  3:44 [U-Boot] [PATCH 1/1] SMC911x driver fixed for NFS boot Manikandan Pillai
2009-04-27 22:20 ` Wolfgang Denk
2009-04-27 22:34   ` Ben Warren
2009-06-09 22:08 ` Wolfgang Denk
2009-06-12 21:04   ` Wolfgang Denk
2009-06-13 13:51     ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-13 13:55       ` [U-Boot] [PATCH 1/2] smc911x: fix warning: large integer implicitly truncated to unsigned type Jean-Christophe PLAGNIOL-VILLARD
2009-06-13 13:55         ` [U-Boot] [PATCH 2/2] smc911x: move function implementation for header to c Jean-Christophe PLAGNIOL-VILLARD
2009-06-13 14:45           ` Mike Frysinger
2009-07-10  6:28         ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A56DF93.3030206@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox