public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm, i2c: added support for the TWSI I2C Interface
Date: Thu, 16 Jul 2009 12:17:12 +0200	[thread overview]
Message-ID: <4A5EFE28.1000209@denx.de> (raw)
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202DDF26FBE@SC-VEXCH1.marvell.com>

Hello Prafulla,

Prafulla Wadaskar wrote:
>> -----Original Message-----
>> From: Heiko Schocher [mailto:hs at denx.de] 
>> Sent: Thursday, July 16, 2009 3:34 PM
>> To: Prafulla Wadaskar
>> Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
>> Subject: Re: arm, i2c: added support for the TWSI I2C Interface
>>
>> Hello Prafulla,
>>
>> Prafulla Wadaskar wrote:
>>>> -----Original Message-----
>>>> From: Heiko Schocher [mailto:hs at denx.de] 
>>>> Sent: Thursday, July 16, 2009 1:31 PM
>>>> To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
>>>> Cc: U-Boot user list
>>>> Subject: arm, i2c: added support for the TWSI I2C Interface
>>>>
>>>> added support for the Hardware I2C TWSI Interface on
>>>> kirkwood SOCs, based on the Linux driver, without IRQ
>>>> support.
>>>>
>>>> Tested on a ARM926EJS (CPU Core Version FEROCEON_88FR131
>>>> SOC Family: KIRKWOOD, KW88F6281) based suen3 board
>>>>
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>> ---
>>>>  drivers/i2c/Makefile      |    1 +
>>>>  drivers/i2c/mv64xxx-i2c.c |  452 
>>> Can you rename this? 
>> Of course, what name do you prefer?
> I will prefer a name kirkwood_i2c.c

Hmm.. I thought twsi_i2c.c ...

>>>> +++++++++++++++++++++++++++++++++++++++++++++
>>>>  2 files changed, 453 insertions(+), 0 deletions(-)
>>>>  create mode 100644 drivers/i2c/mv64xxx-i2c.c
>>>>
>>>> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
>>>> index ef32f13..ce30111 100644
>>>> --- a/drivers/i2c/Makefile
>>>> +++ b/drivers/i2c/Makefile
>>>> @@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += 
>>>> omap1510_i2c.o
>>>>  COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o
>>>>  COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o
>>>>  COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
>>>> +COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.o
>>> Put this in order
>> What do you mean?
> Arrange them in alphabetical order, insert this line between "l" "m"

I think the "alphabetical order" is for the CONFIG_ defines ...
so I used the right place for it ... but, if I rename this define
in CONFIG_DRIVER_I2C_TWSI, it gets another place (between
 COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o
+COBJS-$(CONFIG_DRIVER_I2C_TWSI) += twsi_i2c.o
 COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o)

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-07-16 10:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  8:01 [U-Boot] arm, i2c: added support for the TWSI I2C Interface Heiko Schocher
2009-07-16  8:52 ` Prafulla Wadaskar
2009-07-16 10:03   ` Heiko Schocher
2009-07-16 10:06     ` Prafulla Wadaskar
2009-07-16 10:17       ` Heiko Schocher [this message]
2009-07-16 10:19         ` Prafulla Wadaskar
2009-07-16 11:09           ` Heiko Schocher
2009-07-18 10:55 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 12:42   ` Wolfgang Denk
2009-07-18 12:54   ` Heiko Schocher
2009-07-18 12:57     ` Wolfgang Denk
2009-07-18 13:21       ` Heiko Schocher
2009-07-18 13:50         ` Wolfgang Denk
2009-07-19  5:52           ` Heiko Schocher
2009-07-20  7:59   ` [U-Boot] [PATCH v3] " Heiko Schocher
2009-07-22 21:46     ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23  5:09       ` Prafulla Wadaskar
2009-07-28  7:31     ` Heiko Schocher
2009-07-18 10:56 ` [U-Boot] [PATCH] i2c: use for CONFIGs a common naming convention CONFIG_I2C Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 12:49   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5EFE28.1000209@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox