* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
@ 2009-07-08 8:18 Roy Zang
2009-07-08 14:32 ` Kumar Gala
0 siblings, 1 reply; 10+ messages in thread
From: Roy Zang @ 2009-07-08 8:18 UTC (permalink / raw)
To: u-boot
From: Roy Zang <tie-fei.zang@freescale.com>
Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards.
Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
include/configs/MPC8536DS.h | 1 +
include/configs/MPC8540ADS.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/configs/MPC8536DS.h b/include/configs/MPC8536DS.h
index 9e00b89..e23f8f9 100644
--- a/include/configs/MPC8536DS.h
+++ b/include/configs/MPC8536DS.h
@@ -45,6 +45,7 @@
#define CONFIG_SYS_PCI_64BIT 1 /* enable 64-bit PCI resources */
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */
+#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
#define CONFIG_TSEC_ENET /* tsec ethernet support */
#define CONFIG_ENV_OVERWRITE
diff --git a/include/configs/MPC8540ADS.h b/include/configs/MPC8540ADS.h
index 5253611..327b342 100644
--- a/include/configs/MPC8540ADS.h
+++ b/include/configs/MPC8540ADS.h
@@ -50,6 +50,7 @@
#define CONFIG_TSEC_ENET /* tsec ethernet support */
#define CONFIG_ENV_OVERWRITE
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */
+#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
/*
* sysclk for MPC85xx
--
1.5.6.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-08 8:18 [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards Roy Zang
@ 2009-07-08 14:32 ` Kumar Gala
2009-07-09 2:05 ` Roy Zang
0 siblings, 1 reply; 10+ messages in thread
From: Kumar Gala @ 2009-07-08 14:32 UTC (permalink / raw)
To: u-boot
On Jul 8, 2009, at 3:18 AM, Roy Zang wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
>
> Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards.
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
>
> ---
> include/configs/MPC8536DS.h | 1 +
> include/configs/MPC8540ADS.h | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
The comment says MPC8544, the patch is to MPC8540. Which one is
correct ? :)
- k
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-08 14:32 ` Kumar Gala
@ 2009-07-09 2:05 ` Roy Zang
2009-07-16 21:12 ` Wolfgang Denk
2009-07-21 14:04 ` Kumar Gala
0 siblings, 2 replies; 10+ messages in thread
From: Roy Zang @ 2009-07-09 2:05 UTC (permalink / raw)
To: u-boot
On Wed, 2009-07-08 at 22:32 +0800, Kumar Gala wrote:
>
> On Jul 8, 2009, at 3:18 AM, Roy Zang wrote:
>
> > From: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536
> boards.
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> >
> > ---
> > include/configs/MPC8536DS.h | 1 +
> > include/configs/MPC8540ADS.h | 1 +
> > 2 files changed, 2 insertions(+), 0 deletions(-)
>
> The comment says MPC8544, the patch is to MPC8540. Which one is
> correct ? :)
It is 8544DS board. Thanks.
Sorry for the mistake. It is my oversight when I regenerate the patch
before send out.
Pick up this one:
From: Roy Zang <tie-fei.zang@freescale.com>
Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards.
Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
include/configs/MPC8536DS.h | 1 +
include/configs/MPC8544DS.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/configs/MPC8536DS.h b/include/configs/MPC8536DS.h
index 9e00b89..e23f8f9 100644
--- a/include/configs/MPC8536DS.h
+++ b/include/configs/MPC8536DS.h
@@ -45,6 +45,7 @@
#define CONFIG_SYS_PCI_64BIT 1 /* enable 64-bit PCI resources */
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */
+#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
#define CONFIG_TSEC_ENET /* tsec ethernet support */
#define CONFIG_ENV_OVERWRITE
diff --git a/include/configs/MPC8544DS.h b/include/configs/MPC8544DS.h
index 59cfde6..91f337f 100644
--- a/include/configs/MPC8544DS.h
+++ b/include/configs/MPC8544DS.h
@@ -44,6 +44,7 @@
#define CONFIG_SYS_PCI_64BIT 1 /* enable 64-bit PCI resources */
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */
+#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
#define CONFIG_TSEC_ENET /* tsec ethernet support */
#define CONFIG_ENV_OVERWRITE
--
1.5.6.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-09 2:05 ` Roy Zang
@ 2009-07-16 21:12 ` Wolfgang Denk
2009-07-16 21:22 ` Ben Warren
2009-07-21 14:04 ` Kumar Gala
1 sibling, 1 reply; 10+ messages in thread
From: Wolfgang Denk @ 2009-07-16 21:12 UTC (permalink / raw)
To: u-boot
Dear Roy Zang,
In message <1247105148.29920.3.camel@rock.ap.freescale.net> you wrote:
>
> Sorry for the mistake. It is my oversight when I regenerate the patch
> before send out.
> Pick up this one:
>
> From: Roy Zang <tie-fei.zang@freescale.com>
> Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards.
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
Doesn't apply with git-am. Please use git-format-patch to create
patches.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race has one really effective weapon, and that is laughter.
- Mark Twain
^ permalink raw reply [flat|nested] 10+ messages in thread* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-16 21:12 ` Wolfgang Denk
@ 2009-07-16 21:22 ` Ben Warren
2009-07-16 22:25 ` Wolfgang Denk
2009-07-17 5:21 ` Zang Roy-R61911
0 siblings, 2 replies; 10+ messages in thread
From: Ben Warren @ 2009-07-16 21:22 UTC (permalink / raw)
To: u-boot
Wolfgang Denk wrote:
> Dear Roy Zang,
>
> In message <1247105148.29920.3.camel@rock.ap.freescale.net> you wrote:
>
>> Sorry for the mistake. It is my oversight when I regenerate the patch
>> before send out.
>> Pick up this one:
>>
>> From: Roy Zang <tie-fei.zang@freescale.com>
>> Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards.
>> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
>>
>
> Doesn't apply with git-am. Please use git-format-patch to create
> patches.
>
> Best regards,
>
> Wolfgang Denk
>
>
Still undergoing review (sorry it's taking so long). Please don't apply
yet.
regards,
Ben
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-16 21:22 ` Ben Warren
@ 2009-07-16 22:25 ` Wolfgang Denk
2009-07-17 5:19 ` Zang Roy-R61911
2009-07-17 5:21 ` Zang Roy-R61911
1 sibling, 1 reply; 10+ messages in thread
From: Wolfgang Denk @ 2009-07-16 22:25 UTC (permalink / raw)
To: u-boot
Dear Ben Warren,
In message <4A5F9A05.70104@gmail.com> you wrote:
>
> >> From: Roy Zang <tie-fei.zang@freescale.com>
> >> Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards.
> >> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Doesn't apply with git-am. Please use git-format-patch to create
> > patches.
...
> Still undergoing review (sorry it's taking so long). Please don't apply
> yet.
I did not intend to meddle with your business. Just wanted to point
out formal deficiencies of the patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The existence of god implies a violation of causality.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-16 22:25 ` Wolfgang Denk
@ 2009-07-17 5:19 ` Zang Roy-R61911
0 siblings, 0 replies; 10+ messages in thread
From: Zang Roy-R61911 @ 2009-07-17 5:19 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Friday, July 17, 2009 6:26 AM
> To: Ben Warren
> Cc: Zang Roy-R61911; U-Boot-Denx; Kumar Gala
> Subject: Re: [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet
> support for MPC8544DS and MPC8536 boards
>
> Dear Ben Warren,
>
> In message <4A5F9A05.70104@gmail.com> you wrote:
> >
> > >> From: Roy Zang <tie-fei.zang@freescale.com>
> > >> Add pci/pcie E1000 ethernet support for MPC8544DS and
> MPC8536 boards.
> > >> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> > >
> > > Doesn't apply with git-am. Please use git-format-patch to create
> > > patches.
> ...
> > Still undergoing review (sorry it's taking so long).
> Please don't apply
> > yet.
>
> I did not intend to meddle with your business. Just wanted to point
> out formal deficiencies of the patch.
I always use git-format-patch to create patches :-(.
The issue maybe induced by wrong
format when I reply the mail.
Anyway, I will resend it . Before that, I'd like to get Ben's feedback.
Thanks.
Roy
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-16 21:22 ` Ben Warren
2009-07-16 22:25 ` Wolfgang Denk
@ 2009-07-17 5:21 ` Zang Roy-R61911
1 sibling, 0 replies; 10+ messages in thread
From: Zang Roy-R61911 @ 2009-07-17 5:21 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Ben Warren [mailto:biggerbadderben at gmail.com]
> Sent: Friday, July 17, 2009 5:22 AM
> To: Wolfgang Denk
> Cc: Zang Roy-R61911; U-Boot-Denx; Kumar Gala
> Subject: Re: [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet
> support for MPC8544DS and MPC8536 boards
>
> Wolfgang Denk wrote:
> > Dear Roy Zang,
> >
> > In message <1247105148.29920.3.camel@rock.ap.freescale.net>
> you wrote:
> >
> >> Sorry for the mistake. It is my oversight when I
> regenerate the patch
> >> before send out.
> >> Pick up this one:
> >>
> >> From: Roy Zang <tie-fei.zang@freescale.com>
> >> Add pci/pcie E1000 ethernet support for MPC8544DS and
> MPC8536 boards.
> >> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> >>
> >
> > Doesn't apply with git-am. Please use git-format-patch to create
> > patches.
> >
> > Best regards,
> >
> > Wolfgang Denk
> >
> >
> Still undergoing review (sorry it's taking so long). Please
> don't apply
> yet.
Sorry. It is really long, but I do not see reason to split it :-(.
In fact the kernel file is bigger than this one.
Thanks.
Roy
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-09 2:05 ` Roy Zang
2009-07-16 21:12 ` Wolfgang Denk
@ 2009-07-21 14:04 ` Kumar Gala
2009-07-22 2:24 ` Zang Roy-R61911
1 sibling, 1 reply; 10+ messages in thread
From: Kumar Gala @ 2009-07-21 14:04 UTC (permalink / raw)
To: u-boot
On Jul 8, 2009, at 9:05 PM, Roy Zang wrote:
>> correct ? :)
> It is 8544DS board. Thanks.
> Sorry for the mistake. It is my oversight when I regenerate the patch
> before send out.
> Pick up this one:
>
> From: Roy Zang <tie-fei.zang@freescale.com>
> Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536
> boards.
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
>
> ---
> include/configs/MPC8536DS.h | 1 +
> include/configs/MPC8544DS.h | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
applied
- k
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
2009-07-21 14:04 ` Kumar Gala
@ 2009-07-22 2:24 ` Zang Roy-R61911
0 siblings, 0 replies; 10+ messages in thread
From: Zang Roy-R61911 @ 2009-07-22 2:24 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Tuesday, July 21, 2009 22:04 PM
> To: Zang Roy-R61911
> Cc: U-Boot-Denx
> Subject: Re: PATCH 2/2] Add pci/pcie E1000 ethernet support
> for MPC8544DS and MPC8536 boards
>
>
> On Jul 8, 2009, at 9:05 PM, Roy Zang wrote:
>
> >> correct ? :)
> > It is 8544DS board. Thanks.
> > Sorry for the mistake. It is my oversight when I regenerate
> the patch
> > before send out.
> > Pick up this one:
> >
> > From: Roy Zang <tie-fei.zang@freescale.com>
> > Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536
> > boards.
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> >
> > ---
> > include/configs/MPC8536DS.h | 1 +
> > include/configs/MPC8544DS.h | 1 +
> > 2 files changed, 2 insertions(+), 0 deletions(-)
Then I will send out the individual e1000 driver update to Ben.
Thanks.
Roy
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-07-22 2:24 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-08 8:18 [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards Roy Zang
2009-07-08 14:32 ` Kumar Gala
2009-07-09 2:05 ` Roy Zang
2009-07-16 21:12 ` Wolfgang Denk
2009-07-16 21:22 ` Ben Warren
2009-07-16 22:25 ` Wolfgang Denk
2009-07-17 5:19 ` Zang Roy-R61911
2009-07-17 5:21 ` Zang Roy-R61911
2009-07-21 14:04 ` Kumar Gala
2009-07-22 2:24 ` Zang Roy-R61911
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox