From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 17 Jul 2009 16:32:03 +0200 Subject: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343) In-Reply-To: <1247840636.3953.78.camel@swa-m460> References: <1247836247.3953.65.camel@swa-m460> <4A608781.4050405@denx.de> <1247840636.3953.78.camel@swa-m460> Message-ID: <4A608B63.1060901@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Andr?, Andr? Schwarz wrote: > Heiko, > > this patch is no longer valid since I already posted v2. Ah, ok. > But your comments are correct ... > > Will wait for WD's comments and send v3. OK, one more minor comment ... > On Fri, 2009-07-17 at 16:15 +0200, Heiko Schocher wrote: >> Hello Andr?, >> >> Andr? Schwarz wrote: >>> This patch fixes DDR-II settings and adds I2C support. >>> >>> >>> Signed-off-by: Andr? Schwarz >>> --- >>> >>> include/configs/MVBLM7.h | 48 >>> ++++++++++++++++++++------------------------- >>> 1 files changed, 21 insertions(+), 27 deletions(-) >>> >>> diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h >>> index ac8cb57..6e347e8 100644 >>> --- a/include/configs/MVBLM7.h >>> +++ b/include/configs/MVBLM7.h >>> @@ -47,12 +47,14 @@ >>> #define CONFIG_MPC8XXX_SPI >>> #define CONFIG_HARD_SPI >>> #define MVBLM7_MMC_CS 0x04000000 >>> +#define CONFIG_MISC_INIT_R >> So misc_init_r () gets called, but I didn;t find this in your >> patch? May I miss something ... > > It's included in the other "common code" patch. Hmm... but this will break git-bisect compatibility, and if we have such a tool for searching bugs, we should make patches which are "git bisect compatible" ... so please look, that patches compile clean ... bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany