[U-Boot] [PATCH] mx27: rename fec_imx27 to fec_mxc

[U-Boot] [PATCH] mx27: rename fec_imx27 to fec_mxc

[Ilya Yanok]

Signed-off-by: Ilya Yanok <yanok@emcraft.com>
---
 cpu/arm926ejs/mx27/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/arm926ejs/mx27/generic.c b/cpu/arm926ejs/mx27/generic.c
index b377fad..cbb6c85 100644
--- a/cpu/arm926ejs/mx27/generic.c
+++ b/cpu/arm926ejs/mx27/generic.c
@@ -165,7 +165,7 @@ int print_cpuinfo (void)
 
 int cpu_eth_init(bd_t *bis)
 {
-#if defined(CONFIG_FEC_IMX27)
+#if defined(CONFIG_FEC_MXC)
 	return fecimx27_initialize(bis);
 #else
 	return 0;
-- 
1.6.0.6

[U-Boot] [PATCH] mx27: rename fec_imx27 to fec_mxc

[Wolfgang Denk]

Dear Ilya Yanok,

In message <1247828504-9806-1-git-send-email-yanok@emcraft.com> you wrote:
> 
> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> ---
>  cpu/arm926ejs/mx27/generic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/cpu/arm926ejs/mx27/generic.c b/cpu/arm926ejs/mx27/generic.c
> index b377fad..cbb6c85 100644
> --- a/cpu/arm926ejs/mx27/generic.c
> +++ b/cpu/arm926ejs/mx27/generic.c
> @@ -165,7 +165,7 @@ int print_cpuinfo (void)
>  
>  int cpu_eth_init(bd_t *bis)
>  {
> -#if defined(CONFIG_FEC_IMX27)
> +#if defined(CONFIG_FEC_MXC)
>  	return fecimx27_initialize(bis);

See Ben's comment - renaming the CONFIG_ variable but leaving
fecimx27_initialize() makes no sense.


And this should be no separate patch, but squashed into the patch
that adds the cpu_eth_init() code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The trouble with doing something right the first time is that nobody
appreciates how difficult it was."                        - Walt West

[U-Boot] [PATCH] mx27: rename fec_imx27 to fec_mxc

[Ilya Yanok]

Hi Wolfgang,

Wolfgang Denk wrote:
>> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>> ---
>>  cpu/arm926ejs/mx27/generic.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cpu/arm926ejs/mx27/generic.c b/cpu/arm926ejs/mx27/generic.c
>> index b377fad..cbb6c85 100644
>> --- a/cpu/arm926ejs/mx27/generic.c
>> +++ b/cpu/arm926ejs/mx27/generic.c
>> @@ -165,7 +165,7 @@ int print_cpuinfo (void)
>>  
>>  int cpu_eth_init(bd_t *bis)
>>  {
>> -#if defined(CONFIG_FEC_IMX27)
>> +#if defined(CONFIG_FEC_MXC)
>>  	return fecimx27_initialize(bis);
>>     
>
> See Ben's comment - renaming the CONFIG_ variable but leaving
> fecimx27_initialize() makes no sense.
>   

Yes. That's my fault. I'll fix this and repost the patches.

> And this should be no separate patch, but squashed into the patch
> that adds the cpu_eth_init() code.
>   

Surely. I'll fix this too.

Regards, Ilya.