From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm, i2c: added support for the TWSI I2C Interface
Date: Sat, 18 Jul 2009 15:21:47 +0200 [thread overview]
Message-ID: <4A61CC6B.3090603@denx.de> (raw)
In-Reply-To: <20090718125754.D2CDB832E416@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> In message <4A61C602.10904@denx.de> you wrote:
>> I don;t understand you here. You have a "CONFIG name convention cleanup"
>> patch somewhere? Is this somewhere discussed, how this should
>> look like? (I think, a "CONFIG_DRIVER_I2C_xxx" would be good)
>
> It never has been discussed or even mentioned before.
>
> Jean-Christophe, I recommend you accept Heiko's patch as is (as it was
> submitted before your patch), and then just regenerate your patch
> (which is trivial for you to do as you have the script ready).
Hmm.. I have to fix some comments, which Prafulla suggested, also
to integrate the speed settings ...
So I don;t know, if this patch should go in mainline as it is ...
I think it is easier, if we integrate Jean-Christophes renaming
patch (the reposted version with correct subject ;-)
and then I can easy adapt "my" patch ...
>>>> +static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0;
>>>> +#if defined(CONFIG_I2C_MUX)
>>>> +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) = 0;
>>> .data
>>>> +#endif
>>> no need of put it in section .data on arm
>> Hmm.. I am not an arm expert ...
>
> I disagree with Jean-Christophe here. Do not change this code.
Ok. If Jean-Christophe accept it ...
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-07-18 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 8:01 [U-Boot] arm, i2c: added support for the TWSI I2C Interface Heiko Schocher
2009-07-16 8:52 ` Prafulla Wadaskar
2009-07-16 10:03 ` Heiko Schocher
2009-07-16 10:06 ` Prafulla Wadaskar
2009-07-16 10:17 ` Heiko Schocher
2009-07-16 10:19 ` Prafulla Wadaskar
2009-07-16 11:09 ` Heiko Schocher
2009-07-18 10:55 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 12:42 ` Wolfgang Denk
2009-07-18 12:54 ` Heiko Schocher
2009-07-18 12:57 ` Wolfgang Denk
2009-07-18 13:21 ` Heiko Schocher [this message]
2009-07-18 13:50 ` Wolfgang Denk
2009-07-19 5:52 ` Heiko Schocher
2009-07-20 7:59 ` [U-Boot] [PATCH v3] " Heiko Schocher
2009-07-22 21:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 5:09 ` Prafulla Wadaskar
2009-07-28 7:31 ` Heiko Schocher
2009-07-18 10:56 ` [U-Boot] [PATCH] i2c: use for CONFIGs a common naming convention CONFIG_I2C Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 12:49 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A61CC6B.3090603@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox