public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jens Scharsig <esw@bus-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] new video driver for bus vcxk framebuffers
Date: Mon, 20 Jul 2009 08:45:06 +0200	[thread overview]
Message-ID: <4A641272.9050504@bus-elektronik.de> (raw)
In-Reply-To: <4A61FE3A.9070500@denx.de>

Hello Anatolij,

>> +initialize the reset line to vcxk hardware and release it from reset
> 
> Looking on the changes to board configuration file
> "include/configs/EB+MCF-EV123.h" in the second patch of this series
> I now realize that most of these CONFIG_SYS_ macros above expand to
> C code, so these are not configuration options any more.
> I tend to reject all this. CONFIG_SYS_ options are supposed to be options
> and not board specific code. VCxK.c driver you removed by this patch
> series did it in more correct way, I think.
> What about moving this code to functions which use board specific macros?
> These functions should be placed in this new video driver then.
> 

I will complete review the code.
I think, i can sent a new patch set within one week

Best regards,

Jens Scharsig

  reply	other threads:[~2009-07-20  6:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 14:36 [U-Boot] [PATCH 1/2] new video driver for bus vcxk framebuffers Jens Scharsig
2009-07-17 22:16 ` Wolfgang Denk
2009-07-18 16:54 ` Anatolij Gustschin
2009-07-20  6:45   ` Jens Scharsig [this message]
2009-07-21 11:08 ` [U-Boot] [PATCH 1/2 V2] " Jens Scharsig
2009-07-23 19:40   ` Wolfgang Denk
2009-07-24  8:09     ` Jens Scharsig
2009-07-24  8:09 ` [U-Boot] [PATCH 1/2 V3] " Jens Scharsig
2009-07-26 11:46   ` Anatolij Gustschin
2009-07-27  3:06     ` [U-Boot] [PATCH 1/2 V3] new video driver for bus vcxkframebuffers Robin Getz
2009-07-27  7:49       ` Anatolij Gustschin
2009-08-09 20:46       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A641272.9050504@bus-elektronik.de \
    --to=esw@bus-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox