* [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler
@ 2009-07-20 2:40 Minkyu Kang
2009-07-20 2:42 ` Kyungmin Park
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Minkyu Kang @ 2009-07-20 2:40 UTC (permalink / raw)
To: u-boot
Because of the reset_cpu is soc specific, should be move to soc
Cc: Dirk Behme <dirk.behme@googlemail.com>
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
cpu/arm_cortexa8/omap3/Makefile | 1 +
cpu/arm_cortexa8/omap3/reset.S | 36 ++++++++++++++++++++++++++++++++++++
cpu/arm_cortexa8/start.S | 14 --------------
3 files changed, 37 insertions(+), 14 deletions(-)
create mode 100644 cpu/arm_cortexa8/omap3/reset.S
diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile
index 1fbd0dc..eef165c 100644
--- a/cpu/arm_cortexa8/omap3/Makefile
+++ b/cpu/arm_cortexa8/omap3/Makefile
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
LIB = $(obj)lib$(SOC).a
SOBJS := lowlevel_init.o
+SOBJS += reset.o
COBJS += board.o
COBJS += cache.o
diff --git a/cpu/arm_cortexa8/omap3/reset.S b/cpu/arm_cortexa8/omap3/reset.S
new file mode 100644
index 0000000..a53c408
--- /dev/null
+++ b/cpu/arm_cortexa8/omap3/reset.S
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2009 Samsung Electronics.
+ * Minkyu Kang <mk7.kang@samsung.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+
+.global reset_cpu
+reset_cpu:
+ ldr r1, rstctl @ get addr for global reset
+ @ reg
+ mov r3, #0x2 @ full reset pll + mpu
+ str r3, [r1] @ force reset
+ mov r0, r0
+_loop_forever:
+ b _loop_forever
+rstctl:
+ .word PRM_RSTCTRL
diff --git a/cpu/arm_cortexa8/start.S b/cpu/arm_cortexa8/start.S
index 66b4820..6bd6552 100644
--- a/cpu/arm_cortexa8/start.S
+++ b/cpu/arm_cortexa8/start.S
@@ -500,17 +500,3 @@ finished_inval:
@ but we compile with armv5
ldmfd r13!, {r0 - r5, r7, r9 - r12, pc}
-
-
- .align 5
-.global reset_cpu
-reset_cpu:
- ldr r1, rstctl @ get addr for global reset
- @ reg
- mov r3, #0x2 @ full reset pll + mpu
- str r3, [r1] @ force reset
- mov r0, r0
-_loop_forever:
- b _loop_forever
-rstctl:
- .word PRM_RSTCTRL
--
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler
2009-07-20 2:40 [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler Minkyu Kang
@ 2009-07-20 2:42 ` Kyungmin Park
2009-07-20 15:42 ` Dirk Behme
2009-07-22 21:40 ` Jean-Christophe PLAGNIOL-VILLARD
2 siblings, 0 replies; 4+ messages in thread
From: Kyungmin Park @ 2009-07-20 2:42 UTC (permalink / raw)
To: u-boot
Hi,
It's already discussed. Actually it's required for adding new S5PC1xx
series based on arm cortext8.
Please apply it.
Thank you,
Kyungmin Park
On Mon, Jul 20, 2009 at 11:40 AM, Minkyu Kang<mk7.kang@samsung.com> wrote:
> Because of the reset_cpu is soc specific, should be move to soc
>
> Cc: Dirk Behme <dirk.behme@googlemail.com>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> ?cpu/arm_cortexa8/omap3/Makefile | ? ?1 +
> ?cpu/arm_cortexa8/omap3/reset.S ?| ? 36 ++++++++++++++++++++++++++++++++++++
> ?cpu/arm_cortexa8/start.S ? ? ? ?| ? 14 --------------
> ?3 files changed, 37 insertions(+), 14 deletions(-)
> ?create mode 100644 cpu/arm_cortexa8/omap3/reset.S
>
> diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile
> index 1fbd0dc..eef165c 100644
> --- a/cpu/arm_cortexa8/omap3/Makefile
> +++ b/cpu/arm_cortexa8/omap3/Makefile
> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
> ?LIB ? ?= ?$(obj)lib$(SOC).a
>
> ?SOBJS ?:= lowlevel_init.o
> +SOBJS ?+= reset.o
>
> ?COBJS ?+= board.o
> ?COBJS ?+= cache.o
> diff --git a/cpu/arm_cortexa8/omap3/reset.S b/cpu/arm_cortexa8/omap3/reset.S
> new file mode 100644
> index 0000000..a53c408
> --- /dev/null
> +++ b/cpu/arm_cortexa8/omap3/reset.S
> @@ -0,0 +1,36 @@
> +/*
> + * Copyright (c) 2009 Samsung Electronics.
> + * Minkyu Kang <mk7.kang@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <config.h>
> +
> +.global reset_cpu
> +reset_cpu:
> + ? ? ? ldr ? ? r1, rstctl ? ? ? ? ? ? ? ? ? ? ?@ get addr for global reset
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? @ reg
> + ? ? ? mov ? ? r3, #0x2 ? ? ? ? ? ? ? ? ? ? ? ?@ full reset pll + mpu
> + ? ? ? str ? ? r3, [r1] ? ? ? ? ? ? ? ? ? ? ? ?@ force reset
> + ? ? ? mov ? ? r0, r0
> +_loop_forever:
> + ? ? ? b ? ? ? _loop_forever
> +rstctl:
> + ? ? ? .word ? PRM_RSTCTRL
> diff --git a/cpu/arm_cortexa8/start.S b/cpu/arm_cortexa8/start.S
> index 66b4820..6bd6552 100644
> --- a/cpu/arm_cortexa8/start.S
> +++ b/cpu/arm_cortexa8/start.S
> @@ -500,17 +500,3 @@ finished_inval:
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?@ but we compile with armv5
>
> ? ? ? ?ldmfd ? r13!, {r0 - r5, r7, r9 - r12, pc}
> -
> -
> - ? ? ? .align ?5
> -.global reset_cpu
> -reset_cpu:
> - ? ? ? ldr ? ? r1, rstctl ? ? ? ? ? ? ? ? ? ? ?@ get addr for global reset
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? @ reg
> - ? ? ? mov ? ? r3, #0x2 ? ? ? ? ? ? ? ? ? ? ? ?@ full reset pll + mpu
> - ? ? ? str ? ? r3, [r1] ? ? ? ? ? ? ? ? ? ? ? ?@ force reset
> - ? ? ? mov ? ? r0, r0
> -_loop_forever:
> - ? ? ? b ? ? ? _loop_forever
> -rstctl:
> - ? ? ? .word ? PRM_RSTCTRL
> --
> 1.5.4.3
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler
2009-07-20 2:40 [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler Minkyu Kang
2009-07-20 2:42 ` Kyungmin Park
@ 2009-07-20 15:42 ` Dirk Behme
2009-07-22 21:40 ` Jean-Christophe PLAGNIOL-VILLARD
2 siblings, 0 replies; 4+ messages in thread
From: Dirk Behme @ 2009-07-20 15:42 UTC (permalink / raw)
To: u-boot
Minkyu Kang wrote:
> Because of the reset_cpu is soc specific, should be move to soc
Thanks, looks fine for me.
For the archives, this makes
http://lists.denx.de/pipermail/u-boot/2009-May/053490.html
obsolete.
Dirk
> Cc: Dirk Behme <dirk.behme@googlemail.com>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> cpu/arm_cortexa8/omap3/Makefile | 1 +
> cpu/arm_cortexa8/omap3/reset.S | 36 ++++++++++++++++++++++++++++++++++++
> cpu/arm_cortexa8/start.S | 14 --------------
> 3 files changed, 37 insertions(+), 14 deletions(-)
> create mode 100644 cpu/arm_cortexa8/omap3/reset.S
>
> diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile
> index 1fbd0dc..eef165c 100644
> --- a/cpu/arm_cortexa8/omap3/Makefile
> +++ b/cpu/arm_cortexa8/omap3/Makefile
> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
> LIB = $(obj)lib$(SOC).a
>
> SOBJS := lowlevel_init.o
> +SOBJS += reset.o
>
> COBJS += board.o
> COBJS += cache.o
> diff --git a/cpu/arm_cortexa8/omap3/reset.S b/cpu/arm_cortexa8/omap3/reset.S
> new file mode 100644
> index 0000000..a53c408
> --- /dev/null
> +++ b/cpu/arm_cortexa8/omap3/reset.S
> @@ -0,0 +1,36 @@
> +/*
> + * Copyright (c) 2009 Samsung Electronics.
> + * Minkyu Kang <mk7.kang@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <config.h>
> +
> +.global reset_cpu
> +reset_cpu:
> + ldr r1, rstctl @ get addr for global reset
> + @ reg
> + mov r3, #0x2 @ full reset pll + mpu
> + str r3, [r1] @ force reset
> + mov r0, r0
> +_loop_forever:
> + b _loop_forever
> +rstctl:
> + .word PRM_RSTCTRL
> diff --git a/cpu/arm_cortexa8/start.S b/cpu/arm_cortexa8/start.S
> index 66b4820..6bd6552 100644
> --- a/cpu/arm_cortexa8/start.S
> +++ b/cpu/arm_cortexa8/start.S
> @@ -500,17 +500,3 @@ finished_inval:
> @ but we compile with armv5
>
> ldmfd r13!, {r0 - r5, r7, r9 - r12, pc}
> -
> -
> - .align 5
> -.global reset_cpu
> -reset_cpu:
> - ldr r1, rstctl @ get addr for global reset
> - @ reg
> - mov r3, #0x2 @ full reset pll + mpu
> - str r3, [r1] @ force reset
> - mov r0, r0
> -_loop_forever:
> - b _loop_forever
> -rstctl:
> - .word PRM_RSTCTRL
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler
2009-07-20 2:40 [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler Minkyu Kang
2009-07-20 2:42 ` Kyungmin Park
2009-07-20 15:42 ` Dirk Behme
@ 2009-07-22 21:40 ` Jean-Christophe PLAGNIOL-VILLARD
2 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-07-22 21:40 UTC (permalink / raw)
To: u-boot
On 11:40 Mon 20 Jul , Minkyu Kang wrote:
> Because of the reset_cpu is soc specific, should be move to soc
>
> Cc: Dirk Behme <dirk.behme@googlemail.com>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> cpu/arm_cortexa8/omap3/Makefile | 1 +
> cpu/arm_cortexa8/omap3/reset.S | 36 ++++++++++++++++++++++++++++++++++++
> cpu/arm_cortexa8/start.S | 14 --------------
> 3 files changed, 37 insertions(+), 14 deletions(-)
> create mode 100644 cpu/arm_cortexa8/omap3/reset.S
applied to u-boot-arm
Best Regards,
J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-22 21:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-20 2:40 [U-Boot] [PATCH] ARM Cortex A8: Move OMAP3 specific reset handler Minkyu Kang
2009-07-20 2:42 ` Kyungmin Park
2009-07-20 15:42 ` Dirk Behme
2009-07-22 21:40 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox