public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4]: arm: Kirkwood: Fix compiler optimization bug for kwgbe_send
Date: Mon, 20 Jul 2009 22:40:44 -0700	[thread overview]
Message-ID: <4A6554DC.4050803@gmail.com> (raw)
In-Reply-To: <20090708130318.60a40ec7@marrow.netinsight.se>

Simon Kagstrom wrote:
> kwgbe_send/recv both have loops waiting for the hardware to set  a bit.
> GCC 4.3.3 cleverly optimizes the send case to ... a while(1); loop. This
> patch uses readl to force a read from device memory. Other volatile
> accesses have also been replaced with readl/writel where appropriate
> (as per suggestions on the U-boot mailing list).
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
>  drivers/net/kirkwood_egiga.c |   31 +++++++++++++++++++------------
>  1 files changed, 19 insertions(+), 12 deletions(-)
>   
Applied to net repo.

thanks,

  reply	other threads:[~2009-07-21  5:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08 11:01 [U-Boot] [PATCH 0/4]: arm: Kirkwood: Various egiga fixes Simon Kagstrom
2009-07-08 11:02 ` [U-Boot] [PATCH 1/4]: arm: Kirkwood: Set MAC address during registration for kirkwood egiga Simon Kagstrom
2009-07-09  8:49   ` Prafulla Wadaskar
2009-07-10  5:44   ` Ben Warren
2009-07-10  7:24     ` Simon Kagstrom
2009-07-10  8:15       ` Prafulla Wadaskar
2009-07-11  9:27       ` Wolfgang Denk
2009-07-13  8:13         ` Simon Kagstrom
2009-07-17 18:50           ` Wolfgang Denk
2009-07-11  9:25     ` Wolfgang Denk
2009-07-08 11:03 ` [U-Boot] [PATCH 2/4]: arm: Kirkwood: Fix compiler optimization bug for kwgbe_send Simon Kagstrom
2009-07-21  5:40   ` Ben Warren [this message]
2009-07-21  5:41   ` Ben Warren
2009-07-08 11:05 ` [U-Boot] [PATCH 3/4]: arm: Kirkwood: Check the error summary bit for error detection Simon Kagstrom
2009-07-21  5:42   ` Ben Warren
2009-07-08 11:05 ` [U-Boot] [PATCH 4/4]: arm: Kirkwood: See to it that sent data is 8-byte aligned Simon Kagstrom
2009-07-08 12:17   ` Prafulla Wadaskar
2009-07-08 12:44     ` Simon Kagstrom
2009-07-08 21:03       ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-08 12:35   ` Stefan Roese
2009-07-08 13:04     ` Simon Kagstrom
2009-07-21  5:47   ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6554DC.4050803@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox