From: Felix Radensky <felix@embedded-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ppc4xx: Add GDsys CompactCenter board support.
Date: Tue, 21 Jul 2009 11:05:02 +0300 [thread overview]
Message-ID: <4A6576AE.7040207@embedded-sol.com> (raw)
In-Reply-To: <200907201044.24760.sr@denx.de>
Hi, Stefan
Stefan Roese wrote:
> Felix,
>
> On Wednesday 15 July 2009 11:24:07 Felix Radensky wrote:
>
>> I think my first patch that open-coded part of ft_board_setup() related
>> to EBC ranges
>> was correct and tested on real hardware. I admit that I didn't test the
>> second version
>> of the patch, as I didn't have the hardware at hand.
>>
>> I'll submit a fix soon, but I still don't have hardware for testing, so
>> I'd appreciate your
>> help with that.
>>
>
> Any news on this issue? Would be great if you could find the time to submit a
> patch for this. Dirk (?) and I will do the testing.
>
>
The problem with approach you suggest (copy ranges array, modify first
entry, rewrite
ranges array), is that ranges property doesn't cover all chip selects,
only populated ones,
and NOR is not always on CS0 (in case of boot from NAND). So you don't
really know
which entry should be modified.
Do you have any other ideas how to do this elegantly, without copying code
from generic ft_board_setup() ?
Felix.
Felix.
prev parent reply other threads:[~2009-07-21 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 8:35 [U-Boot] [PATCH v2] ppc4xx: Add GDsys CompactCenter board support Dirk Eibach
2009-07-13 8:57 ` Stefan Roese
2009-07-15 7:28 ` Eibach, Dirk
2009-07-15 9:16 ` Stefan Roese
2009-07-15 9:24 ` Felix Radensky
2009-07-15 9:28 ` Eibach, Dirk
2009-07-20 8:44 ` Stefan Roese
2009-07-21 8:05 ` Felix Radensky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6576AE.7040207@embedded-sol.com \
--to=felix@embedded-sol.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox