public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix
Date: Tue, 21 Jul 2009 14:02:43 -0400	[thread overview]
Message-ID: <4A6602C3.2050007@psyent.com> (raw)
In-Reply-To: <49DF39CD.9010202@imagos.it>

See comments.

> diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c
> index 53fd569..1e8034b 100644
> --- a/lib_nios2/bootm.c
> +++ b/lib_nios2/bootm.c
> @@ -2,6 +2,9 @@
>   * (C) Copyright 2003, Psyent Corporation <www.psyent.com>
>   * Scott McNutt <smcnutt@psyent.com>
>   *
> + * (C) Copyright 2009, Imagos sas <www.imagos.it>
> + * Renato Andreola <renato.andreola@imagos.it>
> + *

Claiming a copyright ...

> +    /* flushes data and instruction caches before calling the kernel */
> +    flush_dcache (0,CONFIG_SYS_DCACHE_SIZE );
> +    flush_icache (0,CONFIG_SYS_ICACHE_SIZE);

... for a two line bug fix?

This is hardly a valid reason to claim copyright on the module.

This practice will only discourage the contribution of original work
to the project. Nobody wants to have their work hijacked in such a
manner.

Please resubmit.

Regards,
--Scott

  parent reply	other threads:[~2009-07-21 18:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 12:21 [U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix Renato Andreola
2009-07-17 22:13 ` Wolfgang Denk
2009-07-21 18:02 ` Scott McNutt [this message]
2009-07-22  8:01   ` [U-Boot] Rejected: " Renato Andreola
2009-07-22  9:43     ` Wolfgang Denk
2009-07-22  9:41   ` Wolfgang Wegner
2009-07-22 10:56     ` Wolfgang Denk
2009-07-22 10:33       ` Wolfgang Wegner
2009-07-22 14:54         ` Wolfgang Denk
2009-07-23  1:41     ` Scott McNutt
2009-11-22 20:12 ` [U-Boot] " Wolfgang Denk
2009-11-23 21:52   ` Scott McNutt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6602C3.2050007@psyent.com \
    --to=smcnutt@psyent.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox