[U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

Scott McNutt
2009-07-21T18:02:43Z

See comments.

> diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c
> index 53fd569..1e8034b 100644
> --- a/lib_nios2/bootm.c
> +++ b/lib_nios2/bootm.c
> @@ -2,6 +2,9 @@
> * (C) Copyright 2003, Psyent Corporation <www.psyent.com>
> * Scott McNutt <smcnutt@psyent.com>
> *
> + * (C) Copyright 2009, Imagos sas <www.imagos.it>
> + * Renato Andreola <renato.andreola@imagos.it>
> + *

Claiming a copyright ...

> + /* flushes data and instruction caches before calling the kernel */
> + flush_dcache (0,CONFIG_SYS_DCACHE_SIZE );
> + flush_icache (0,CONFIG_SYS_ICACHE_SIZE);

... for a two line bug fix?

This is hardly a valid reason to claim copyright on the module.

This practice will only discourage the contribution of original work
to the project. Nobody wants to have their work hijacked in such a
manner.

Please resubmit.

Regards,
--Scott