[U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

Wolfgang Denk
2009-07-22T10:56:52Z

Dear Wolfgang Wegner,

In message <20090722094127.GV20598@leila.ping.de> you wrote:
>
> So you really think your practice will encourage anybody to submit a
> clean patch for a bug he spent days (or weeks) to find?

That's how the public review process works: You submit a patch, and it
either gets accepted or rejected. If it gets rejected, you gotta
rework it again (and again, if necessary) until it gets accepted.

This is not different for you or for me or for anybody else.

If you submit a patch that gets accepted you at least 1) know that
the problem is fixed in mainline, i. e. once and for ever, and 2) you
receive the full credit for it because you show up as the author of
the commit.

If you don't do that, then either somebody else will clean up your
patch and commit it and earn the credits for your work, or nobody will
care and the problem remains, which means your work was basicly
wasted.

Your choice.

> On the one hand, you want patches to be tested (which is a good thing,
> of course), on the other hand I can not test a patch without other
> things changed for my board (which is not really useful for inclusion
> in the official tree, I think). Keeping several trees up-to-date to
> test the patches out of the vanilla tree and then rolling them back into
> the vanilly tree is at least beyond my time scale (and, to be honest,
> sometimes my knowledge of git, which is not self-explanatory at all).

Well, we cannot save you the effort of learning git. We all had to go
through this ourself. But I can promise that it is very well invested
effort which will pay back very quickly.

Um... and instead of maintaining several private source trees you
should consider poushing your code upstream, so that others do the
maintenance for you.

> I can understand the maintainers have not that much time, I can also
> understand that the original work has to get its due credit - but then
> those sending patches should get their credit, too, or else the maintainer
> has to do the work of integrating the fix himself.

You get the credit by being the author of the commit, and by your
Signed-off-by: line in it. "git log" will show it, "git blame" will
show it, and you will find your place in the U-Boot statistics page,
too. You do not have any entitlement on a (C) Copyright entry in a
bigger source file if you change just a few lines in it. That's not
reasonable.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are some good people in it, but the orchestra as a whole is
equivalent to a gang bent on destruction." - John Cage, composer