* [U-Boot] include/asm-ppc/immap_86xx.h
@ 2009-07-22 15:16 David Updegraff
2009-07-22 15:28 ` Kumar Gala
2009-07-23 15:13 ` Kumar Gala
0 siblings, 2 replies; 3+ messages in thread
From: David Updegraff @ 2009-07-22 15:16 UTC (permalink / raw)
To: u-boot
Hi.
I think there is a small offset bug in here.. unless there is an errata
that I have missed there should be no pad between srds1cr0,1. Anyone
know for sure?
--- a/include/asm-ppc/immap_86xx.h
+++ b/include/asm-ppc/immap_86xx.h
@@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
uint lbcdllcr; /* 0xe0e20 - LBC DLL control register */
char res13a[224];
uint srds1cr0; /* 0xe0f04 - SerDes1 control register 0 */
- char res13b[4];
+ //char res13b[4];
uint srds1cr1; /* 0xe0f08 - SerDes1 control register 1 */
char res14[24];
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] include/asm-ppc/immap_86xx.h
2009-07-22 15:16 [U-Boot] include/asm-ppc/immap_86xx.h David Updegraff
@ 2009-07-22 15:28 ` Kumar Gala
2009-07-23 15:13 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2009-07-22 15:28 UTC (permalink / raw)
To: u-boot
On Jul 22, 2009, at 10:16 AM, David Updegraff wrote:
> Hi.
>
> I think there is a small offset bug in here.. unless there is an
> errata
> that I have missed there should be no pad between srds1cr0,1. Anyone
> know for sure?
>
>
> --- a/include/asm-ppc/immap_86xx.h
> +++ b/include/asm-ppc/immap_86xx.h
> @@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
> uint lbcdllcr; /* 0xe0e20 - LBC DLL control
> register */
> char res13a[224];
> uint srds1cr0; /* 0xe0f04 - SerDes1 control
> register 0 */
> - char res13b[4];
> + //char res13b[4];
> uint srds1cr1; /* 0xe0f08 - SerDes1 control
> register 1 */
> char res14[24];
I'm guessing this is a bug in the manual, but will look into it.
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] include/asm-ppc/immap_86xx.h
2009-07-22 15:16 [U-Boot] include/asm-ppc/immap_86xx.h David Updegraff
2009-07-22 15:28 ` Kumar Gala
@ 2009-07-23 15:13 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2009-07-23 15:13 UTC (permalink / raw)
To: u-boot
On Jul 22, 2009, at 10:16 AM, David Updegraff wrote:
> Hi.
>
> I think there is a small offset bug in here.. unless there is an
> errata
> that I have missed there should be no pad between srds1cr0,1. Anyone
> know for sure?
>
>
> --- a/include/asm-ppc/immap_86xx.h
> +++ b/include/asm-ppc/immap_86xx.h
> @@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
> uint lbcdllcr; /* 0xe0e20 - LBC DLL control
> register */
> char res13a[224];
> uint srds1cr0; /* 0xe0f04 - SerDes1 control
> register 0 */
> - char res13b[4];
> + //char res13b[4];
> uint srds1cr1; /* 0xe0f08 - SerDes1 control
> register 1 */
> char res14[24];
I've verified and the manual is correct and the code is wrong. If you
send a proper patch I'll apply it.
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-23 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-22 15:16 [U-Boot] include/asm-ppc/immap_86xx.h David Updegraff
2009-07-22 15:28 ` Kumar Gala
2009-07-23 15:13 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox