From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Wed, 22 Jul 2009 22:24:16 -0700
Subject: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC
In-Reply-To: <20090722215122.GA26867@game.jcrosoft.org>
References: <1247750640-1639-1-git-send-email-eric@eukrea.com>
	<20090718152741.GF30699@game.jcrosoft.org>
	<20090722215122.GA26867@game.jcrosoft.org>
Message-ID: <4A67F400.6070606@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>  
>>> -SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
>>> -OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
>>> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
>>> +OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
>>>  
>>>  all:	$(obj).depend $(LIB)
>>>  
>>> diff --git a/cpu/arm920t/at91rm9200/ks8721.c b/cpu/arm920t/at91rm9200/ks8721.c
>>> new file mode 100644
>>> index 0000000..703e58c
>>> --- /dev/null
>>> +++ b/cpu/arm920t/at91rm9200/ks8721.c
>>> @@ -0,0 +1,244 @@
>>> +/*
>>> + * (C) Copyright 2006
>>> + * Author : Eric Benard (Eukrea Electromatique)
>>> + * based on dm9161.c which is :
>>> + * (C) Copyright 2003
>>> + * Author : Hamid Ikdoumi (Atmel)
>>>       
>> I'm not a fan of this implementation at all
>>
>> but as I've not yet finish the rm9200 cleanup
>> I'll ack this ben what do you think?
>> ben please note that the rm9200 cleanup will introduce a phylib support
>>     
> Ben ping
>
> Best Regards,
> J.
>   
This patch has many coding style violations that haven't been addressed, 
so it can't go in.  I"m not a fan of the piece-meal PHY implementation 
either, but realize that a real PHY lib isn't imminent, unless your 
rm2000 implementation is useful across architectures.

regards,
Ben