From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC
Date: Wed, 22 Jul 2009 23:08:13 -0700 [thread overview]
Message-ID: <4A67FE4D.6050604@gmail.com> (raw)
In-Reply-To: <4A67FB35.8010107@eukrea.com>
Eric B?nard wrote:
> Ben Warren wrote :
>> This patch has many coding style violations that haven't been
>> addressed, so it can't go in. I"m not a fan of the piece-meal PHY
>> implementation
>
> coding style violations should be fixed in v3 /
> http://www.mail-archive.com/u-boot at lists.denx.de/msg18068.html
>
> Eric
Not quite. Camel-case function names like 'ks8721_IsPhyConnected'
violate the coding style.
regards,
Ben
next prev parent reply other threads:[~2009-07-23 6:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 13:24 [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC Eric Benard
2009-07-18 15:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 17:14 ` Eric Bénard
2009-07-18 17:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 20:10 ` Eric Benard
2009-07-18 20:32 ` Wolfgang Denk
2009-07-18 22:09 ` [U-Boot] [PATCH v3] " Eric Benard
2009-07-23 22:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 22:41 ` Wolfgang Denk
2009-07-23 22:55 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-22 21:51 ` [U-Boot] [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 5:24 ` Ben Warren
2009-07-23 5:55 ` Eric Bénard
2009-07-23 6:08 ` Ben Warren [this message]
2009-07-30 19:18 ` [U-Boot] [PATCH] " Eric Benard
2009-08-01 9:40 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-01 15:40 ` Eric Bénard
2009-08-09 11:13 ` [U-Boot] [PATCH v5] " Eric Benard
2009-08-09 13:01 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-09 20:09 ` Wolfgang Denk
2009-08-09 20:24 ` Wolfgang Denk
2009-08-09 21:11 ` Dirk Behme
2009-08-09 21:34 ` Wolfgang Denk
2009-08-09 21:54 ` [U-Boot] [PATCH v6] " Eric Benard
2009-08-09 11:15 ` [U-Boot] [PATCH v5] Cosmetic fix in MAKEALL as a separate patch Eric Benard
2009-08-09 20:20 ` Wolfgang Denk
2009-07-23 21:39 ` [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 21:43 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A67FE4D.6050604@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox