From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 22 Jul 2009 23:08:13 -0700 Subject: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC In-Reply-To: <4A67FB35.8010107@eukrea.com> References: <1247750640-1639-1-git-send-email-eric@eukrea.com> <20090718152741.GF30699@game.jcrosoft.org> <20090722215122.GA26867@game.jcrosoft.org> <4A67F400.6070606@gmail.com> <4A67FB35.8010107@eukrea.com> Message-ID: <4A67FE4D.6050604@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Eric B?nard wrote: > Ben Warren wrote : >> This patch has many coding style violations that haven't been >> addressed, so it can't go in. I"m not a fan of the piece-meal PHY >> implementation > > coding style violations should be fixed in v3 / > http://www.mail-archive.com/u-boot at lists.denx.de/msg18068.html > > Eric Not quite. Camel-case function names like 'ks8721_IsPhyConnected' violate the coding style. regards, Ben