From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH/RFC] net: defragment IP packets
Date: Sun, 26 Jul 2009 22:08:31 -0700 [thread overview]
Message-ID: <4A6D364F.3080603@gmail.com> (raw)
In-Reply-To: <20090726202314.GA10969@mail.gnudd.com>
Hi Guys,
Alessandro Rubini wrote:
>>> <http://www.faqs.org/rfcs/rfc815.html>
>>>
>> Yeah, I had seen this - but didn't want to duplicate something that Alessandro
>> might already working on...
>>
>> Alessandro - were you going to add out of order packets?
>>
>
> If the code has chances to go mainline, I'll be happy to complete this
> task. So unless I get a nak earlier, I'm going to find a time slot in
> the next few days (with your fixes, I suppose, or should they remain
> separate patches?)
>
>
>> To make your host send out of order/delayed packets, which should be
>> more "real world/long haul" try something like:
>> # modprobe sch_netem (if it's not compiled into your kernel)
>> # tc qdisc change dev eth0 root netem reorder 50% delay 10ms
>>
>
> Thanks a lot, I was missing that.
> /alessandro
>
This is great work. Thanks! If you follow these guidelines, I'll pull
it into the net repo:
1. Configurable block size (via a well-named CONFIG). Choose a good
default value.
2. Handle out-of-order fragments, and some test results showing that it
works.
3. Make the feature configurable
4. Test with a TFTP server that doesn't have blksize feature enabled
I'm not sure about how to handle the configurability of this feature. I
can see this being the default configuration in the future, but for now
it should probably be opt-in. Let's see how it goes.
regards,
Ben
next prev parent reply other threads:[~2009-07-27 5:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 8:04 [U-Boot] [PATCH/RFC] net: defragment IP packets Alessandro Rubini
2009-07-25 22:09 ` Robin Getz
2009-07-26 2:02 ` Jerry Van Baren
2009-07-26 4:44 ` Robin Getz
2009-07-26 20:23 ` Alessandro Rubini
2009-07-27 0:19 ` Robin Getz
2009-07-27 5:08 ` Ben Warren [this message]
2009-07-27 11:46 ` Robin Getz
2009-07-27 0:59 ` Robin Getz
2009-07-27 12:13 ` Alessandro Rubini
2009-07-27 12:52 ` Robin Getz
2009-07-27 12:41 ` Wolfgang Denk
2009-07-27 12:50 ` Robin Getz
2009-07-27 11:41 ` Robin Getz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6D364F.3080603@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox