From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Sun, 26 Jul 2009 22:08:31 -0700 Subject: [U-Boot] [PATCH/RFC] net: defragment IP packets In-Reply-To: <20090726202314.GA10969@mail.gnudd.com> References: <200907260044.01060.rgetz@blackfin.uclinux.org> <20090724080449.GA19910@mail.gnudd.com> <200907251809.07327.rgetz@blackfin.uclinux.org> <4A6BB948.1000900@gmail.com> <20090726202314.GA10969@mail.gnudd.com> Message-ID: <4A6D364F.3080603@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Guys, Alessandro Rubini wrote: >>> >>> >> Yeah, I had seen this - but didn't want to duplicate something that Alessandro >> might already working on... >> >> Alessandro - were you going to add out of order packets? >> > > If the code has chances to go mainline, I'll be happy to complete this > task. So unless I get a nak earlier, I'm going to find a time slot in > the next few days (with your fixes, I suppose, or should they remain > separate patches?) > > >> To make your host send out of order/delayed packets, which should be >> more "real world/long haul" try something like: >> # modprobe sch_netem (if it's not compiled into your kernel) >> # tc qdisc change dev eth0 root netem reorder 50% delay 10ms >> > > Thanks a lot, I was missing that. > /alessandro > This is great work. Thanks! If you follow these guidelines, I'll pull it into the net repo: 1. Configurable block size (via a well-named CONFIG). Choose a good default value. 2. Handle out-of-order fragments, and some test results showing that it works. 3. Make the feature configurable 4. Test with a TFTP server that doesn't have blksize feature enabled I'm not sure about how to handle the configurability of this feature. I can see this being the default configuration in the future, but for now it should probably be opt-in. Let's see how it goes. regards, Ben