From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2 V3] new video driver for bus vcxkframebuffers
Date: Mon, 27 Jul 2009 09:49:28 +0200 [thread overview]
Message-ID: <4A6D5C08.7020207@denx.de> (raw)
In-Reply-To: <200907262306.19962.rgetz@blackfin.uclinux.org>
Robin Getz wrote:
> On Sun 26 Jul 2009 07:46, Anatolij Gustschin pondered:
...
>> Applied to u-boot-video. Thanks! Note that I had to fix lots
>> of style issues before applying. Next time please use
>> scripts/checkpatch.pl from the Linux source tree to
>> check your patches before submitting them and resolve
>> reported issues were it makes sence. Thanks.
>
> Is there a reason not to include the checkpatch.pl in
> http://www.denx.de/wiki/U-Boot/Patches or in the README (in the Submitting
> Patches section) if it is going to be a requirement?
It is not a requirement, but would make submitter's and our
life easier. Some errors/warnings reported by checkpatch.pl
might cause additional confusion as they apply only for
Linux patches. In this case I suggested to use checkpatch
because v3 of the patch still had style issues pointed out
in the comments to the first version.
Best regards,
Anatolij
next prev parent reply other threads:[~2009-07-27 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 14:36 [U-Boot] [PATCH 1/2] new video driver for bus vcxk framebuffers Jens Scharsig
2009-07-17 22:16 ` Wolfgang Denk
2009-07-18 16:54 ` Anatolij Gustschin
2009-07-20 6:45 ` Jens Scharsig
2009-07-21 11:08 ` [U-Boot] [PATCH 1/2 V2] " Jens Scharsig
2009-07-23 19:40 ` Wolfgang Denk
2009-07-24 8:09 ` Jens Scharsig
2009-07-24 8:09 ` [U-Boot] [PATCH 1/2 V3] " Jens Scharsig
2009-07-26 11:46 ` Anatolij Gustschin
2009-07-27 3:06 ` [U-Boot] [PATCH 1/2 V3] new video driver for bus vcxkframebuffers Robin Getz
2009-07-27 7:49 ` Anatolij Gustschin [this message]
2009-08-09 20:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6D5C08.7020207@denx.de \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox