From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Mon, 27 Jul 2009 09:49:28 +0200 Subject: [U-Boot] [PATCH 1/2 V3] new video driver for bus vcxkframebuffers In-Reply-To: <200907262306.19962.rgetz@blackfin.uclinux.org> References: <4A696C1E.5000609@bus-elektronik.de> <4A6C41F8.4090402@denx.de> <200907262306.19962.rgetz@blackfin.uclinux.org> Message-ID: <4A6D5C08.7020207@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Robin Getz wrote: > On Sun 26 Jul 2009 07:46, Anatolij Gustschin pondered: ... >> Applied to u-boot-video. Thanks! Note that I had to fix lots >> of style issues before applying. Next time please use >> scripts/checkpatch.pl from the Linux source tree to >> check your patches before submitting them and resolve >> reported issues were it makes sence. Thanks. > > Is there a reason not to include the checkpatch.pl in > http://www.denx.de/wiki/U-Boot/Patches or in the README (in the Submitting > Patches section) if it is going to be a requirement? It is not a requirement, but would make submitter's and our life easier. Some errors/warnings reported by checkpatch.pl might cause additional confusion as they apply only for Linux patches. In this case I suggested to use checkpatch because v3 of the patch still had style issues pointed out in the comments to the first version. Best regards, Anatolij