public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [Patch] Fix compiler warning vcxk
@ 2009-07-27 13:28 Jens Scharsig
  2009-07-28  5:58 ` Anatolij Gustschin
  2009-08-09 20:49 ` Wolfgang Denk
  0 siblings, 2 replies; 5+ messages in thread
From: Jens Scharsig @ 2009-07-27 13:28 UTC (permalink / raw)
  To: u-boot

My new video driver vcxk produce a compiler warning.

I'm sorry about this.

This patch will 

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

Signed-off-by: Jens Scharsig <esw@bus-elektronik.de>
---

diff --git a/drivers/video/bus_vcxk.c b/drivers/video/bus_vcxk.c
index b3b53e1..7726bb3 100644
--- a/drivers/video/bus_vcxk.c
+++ b/drivers/video/bus_vcxk.c
@@ -380,7 +380,6 @@ int vcxk_display_bitmap(ulong addr, int x, int y)
 	unsigned long c_width;
 	unsigned long c_height;
 	unsigned char *dataptr;
-	unsigned char *lineptr;
 
 	bmp = (bmp_image_t *) addr;
 	if ((bmp->header.signature[0] == 'B') &&

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [Patch] Fix compiler warning vcxk
  2009-07-27 13:28 [U-Boot] [Patch] Fix compiler warning vcxk Jens Scharsig
@ 2009-07-28  5:58 ` Anatolij Gustschin
  2009-07-28  6:18   ` Jens Scharsig
  2009-08-09 20:49 ` Wolfgang Denk
  1 sibling, 1 reply; 5+ messages in thread
From: Anatolij Gustschin @ 2009-07-28  5:58 UTC (permalink / raw)
  To: u-boot

Jens Scharsig wrote:
> My new video driver vcxk produce a compiler warning.
> 
> I'm sorry about this.
> 
> This patch will 
> 
> * FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
> 
> Signed-off-by: Jens Scharsig <esw@bus-elektronik.de>
> ---

Applied to u-boot-video/master. Thanks.

Please note that comments to the patch should go below "---"
line so that they do not appear in the commit message, e.g.
in this case:

This patch will

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

Your SOB
---
Here is the place for comments which should not appear in
the commit log, in this case this is:

"My new video driver vcxk produce a compiler warning.

I'm sorry about this."

Best regards,
Anatolij

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [Patch] Fix compiler warning vcxk
  2009-07-28  5:58 ` Anatolij Gustschin
@ 2009-07-28  6:18   ` Jens Scharsig
  0 siblings, 0 replies; 5+ messages in thread
From: Jens Scharsig @ 2009-07-28  6:18 UTC (permalink / raw)
  To: u-boot

Anatolij Gustschin wrote:
> 
> Please note that comments to the patch should go below "---"
> line so that they do not appear in the commit message, e.g.
> in this case:
> 
> This patch will
> 
> * FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
> 
> Your SOB
> ---
> Here is the place for comments which should not appear in
> the commit log, in this case this is:
> 
> "My new video driver vcxk produce a compiler warning.
> 

I think the http://www.denx.de/wiki/U-Boot/Patches is a good 
place to describe such basic things. Especially for people 
who publish their first patch.

Best regard

Jens

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [Patch] Fix compiler warning vcxk
  2009-07-27 13:28 [U-Boot] [Patch] Fix compiler warning vcxk Jens Scharsig
  2009-07-28  5:58 ` Anatolij Gustschin
@ 2009-08-09 20:49 ` Wolfgang Denk
  2009-08-10  6:16   ` Jens Scharsig
  1 sibling, 1 reply; 5+ messages in thread
From: Wolfgang Denk @ 2009-08-09 20:49 UTC (permalink / raw)
  To: u-boot

Dear Jens Scharsig,

In message <h4ka2d$mpo$1@ger.gmane.org> you wrote:
> My new video driver vcxk produce a compiler warning.
> 
> I'm sorry about this.
> 
> This patch will 
> 
> * FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
> 
> Signed-off-by: Jens Scharsig <esw@bus-elektronik.de>
> ---

Applied (after editing the commit message; hope this is OK).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think there's a world market for about five computers.
         -- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [Patch] Fix compiler warning vcxk
  2009-08-09 20:49 ` Wolfgang Denk
@ 2009-08-10  6:16   ` Jens Scharsig
  0 siblings, 0 replies; 5+ messages in thread
From: Jens Scharsig @ 2009-08-10  6:16 UTC (permalink / raw)
  To: u-boot

Dear Wolfgang Denk,

> Applied (after editing the commit message; hope this is OK).

No problem, the change commit message describes the right thing.

best regards 

Jens  Scharsig

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-08-10  6:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-27 13:28 [U-Boot] [Patch] Fix compiler warning vcxk Jens Scharsig
2009-07-28  5:58 ` Anatolij Gustschin
2009-07-28  6:18   ` Jens Scharsig
2009-08-09 20:49 ` Wolfgang Denk
2009-08-10  6:16   ` Jens Scharsig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox