From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 28 Jul 2009 12:26:26 +0200 Subject: [U-Boot] [PATCH v2 2/2] arm nomadik: add i2c In-Reply-To: <20090728094104.GI5259@game.jcrosoft.org> References: <0e975ff141a9923b58859fad00cf3df664f2fe04.1248427487.git.rubini@unipv.it> <0b10781c46b757737db8ff5e49c2b8b745c9f269.1248427487.git.rubini@unipv.it> <20090727200408.GC5259@game.jcrosoft.org> <4A6EADE6.4040903@denx.de> <20090728094104.GI5259@game.jcrosoft.org> Message-ID: <4A6ED252.40702@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> it will better to define a couple of generic function where we implement it >>> as this >>> i2c_sda() >>> i2c_scl() >>> i2c_read() >>> i2c_activate() >>> i2c_tristate() >>> i2c_delay() >>> i2c_get_bus_num() >>> i2c_set_bus_num() >>> i2c_get_bus_speed() >>> i2c_set_bus_speed() >>> i2c_init() >> I posted such a suggestion in this thread, see: >> http://lists.denx.de/pipermail/u-boot/2009-July/056934.html > I've forget to mention it but we offcource can do it in 2 step > > so you have my ack to applied it with the gpio patch > as IMHO it more i2c than ARM OK, so I pick up this two patches with your Acked-by. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany