public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] stxamc8548: initial commit
Date: Mon, 03 Aug 2009 23:04:57 -0500	[thread overview]
Message-ID: <4A77B369.5060600@xes-inc.com> (raw)
In-Reply-To: <481420.29932.qm@web37601.mail.mud.yahoo.com>

Hi Alex,

Alex Dubov wrote:
>> When you say its an "old" board, hopefully its still being used.  ie
>> adding support for an "old" board still has some value? :)
> 
> The board is still for sale, even though it's not recommended for new
> designs.
> 
> http://www.silicontkx.com/AMC8548.htm
> 
> But then, there are not that many boards for RapidIO development, so the
> board is still very much in use by people who do this style of work.
> 
> As to the most of the other issues: I mostly used copy/paste from other board
> configs to do fix up my board's setup. Can you recommend a particular board
> config which can serve a style reference? Freescale's MPC8548CDS is even
> less prettier than my stuff.

I don't think any board is "perfect".  As time goes on standards seem 
to keep getting higher, which is a good thing.  Most of the boards you'd 
base your patches off were accepted when the bar was a bit lower, so 
they have some of the same issues pointed out in your patch.

Your patch seems relatively close to being accepted though, so I'd 
recommend just fixing up the issues Wolfgang and I pointed out and 
resubmitting.  It might take an iteration or 2 to get it accepted, but 
it shouldn't take too much more work hopefully.

Best,
Peter

      reply	other threads:[~2009-08-04  4:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03  5:24 [U-Boot] [PATCH] stxamc8548: initial commit Alex Dubov
2009-08-03 14:55 ` Peter Tyser
2009-08-03 19:26 ` Wolfgang Denk
2009-08-04  3:02   ` Alex Dubov
2009-08-04  4:04     ` Peter Tyser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A77B369.5060600@xes-inc.com \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox