[U-Boot] [RFC PATCH] Add support for Raidsonic ICYBOX NAS4220 board

Wolfgang Denk
2009-08-04T20:40:38Z

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090804194155.GA4638@game.jcrosoft.org> you wrote:
>
...
> > >> +
> > >> + ldr r3, =GEMINI_GLOBAL_ID /* Global ID reg */
> > >> + ldr r4, [r3]
> > >> + ldr r5, =0xFF /* Chip revision mask */
> > >> + and r4, r4, r5
> > > please create a function for this and call it
> >
> > it is used only single time. why do you recommend to create function?
> because it will interesting to have it in the board info and a lot's of time
> you will need it in drivers

Obviously this is not the case - he wrote: "used only single time".

Making it a function makes no sense to me then - especially since
we're just talking about 4 LOC...

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It is better to have tried and failed than to have failed to try,
but the result's the same." - Mike Dennison