[U-Boot] [RFC PATCH] Add support for Raidsonic ICYBOX NAS4220 board

Po-Yu Chuang
2009-07-03T04:38:50Z

Dear Darius Augulis,

2009/7/1 Darius Augulis <augulis.darius@gmail.com>:
> This board is based on Cortina Systems networking processor
> CS3516. It has FA526 core, which is ARMv4 compatible.
> Many SoC specific definitions may be used for similar
> processors CS3512 and dual-core CS3518. This processor
> family has Gemini name.
>
> Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
> ---
> diff --git a/cpu/arm920t/start.S b/cpu/arm920t/start.S
> index 475cdaf..761753e 100644
> --- a/cpu/arm920t/start.S
> +++ b/cpu/arm920t/start.S
> @@ -115,8 +115,10 @@ start_code:
> ? ? ? ?orr ? ? r0,r0,#0xd3
> ? ? ? ?msr ? ? cpsr,r0
>
> - ? ? ? bl coloured_LED_init
> - ? ? ? bl red_LED_on
> +#ifndef CONFIG_GEMINI
> + ? ? ? bl ? ? ?coloured_LED_init
> + ? ? ? bl ? ? ?red_LED_on
> +#endif
This is unnecessary.

> ?#if ? ?defined(CONFIG_AT91RM9200DK) || defined(CONFIG_AT91RM9200EK)
> ? ? ? ?/*
> @@ -189,6 +191,11 @@ relocate: ? ? ? ? ? ? ? ? ? ? ? ? ?/* relocate U-Boot to RAM ? ? ? ? ? */
> ? ? ? ?sub ? ? r2, r3, r2 ? ? ? ? ? ? ?/* r2 <- size of armboot ? ? ? ? ? ?*/
> ? ? ? ?add ? ? r2, r0, r2 ? ? ? ? ? ? ?/* r2 <- source end address ? ? ? ? */
>
> +#ifdef CONFIG_GEMINI
> + ? ? ? orr ? ? r0, r0, #CONFIG_SYS_FLASH_BASE
> + ? ? ? orr ? ? r2, r2, #CONFIG_SYS_FLASH_BASE
> +#endif

How about put a jump to the Flash at the very beginning of "start_code"?

start_code:
ldr r0, _start_from_flash
orr pc, r0, #CONFIG_SYS_FLASH_BASE

_start_from_flash: .word start_from_flash

start_from_flash:
/* original start code here*/

Then maybe you don't need a customized linker script?

regards,
Po-Yu Chuang