public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: sync env ethaddr to device enetaddr in eth_init()
Date: Wed, 05 Aug 2009 14:26:50 -0700	[thread overview]
Message-ID: <4A79F91A.4060005@gmail.com> (raw)
In-Reply-To: <20090805212457.DE547832E416@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Ben,
>
> In message <1247707888-5415-1-git-send-email-vapier@gentoo.org> Mike Frysinger wrote:
>   
>> In the previous enetaddr refactoring, the assumption with commit 56b555a644
>> was that the eth layer would handle the env -> device enetaddr syncing.
>> This was not the case as eth_initialize() is called only once and the sync
>> occurs there.  So make sure the eth_init() function does the env -> device
>> sync with every network init.
>>
>> Reported-by: Andrzej Wolski <awolski@poczta.fm>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> ---
>> Andrzej: please try this patch instead for your macb troubles
>>
>>  include/net.h |    2 +-
>>  net/eth.c     |   52 +++++++++++++++++++++++-----------------------------
>>  2 files changed, 24 insertions(+), 30 deletions(-)
>>     
>
> Ping...
>
> Best regards,
>
> Wolfgang Denk
>
>   
This came after the merge window closed, but appears to be a bug fix so 
I'll process tonight.

regards,
Ben

  reply	other threads:[~2009-08-05 21:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  1:31 [U-Boot] [PATCH] net: sync env ethaddr to device enetaddr in eth_init() Mike Frysinger
2009-07-17 14:25 ` Andrzej Wolski
2009-08-05 21:24 ` Wolfgang Denk
2009-08-05 21:26   ` Ben Warren [this message]
2009-08-13  5:21     ` Mike Frysinger
2009-08-08  0:43 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A79F91A.4060005@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox