[U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

[U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

[Renato Andreola]

 From b75bd27f89ac6c105cebb6507cf082b6f5fffc7d Mon Sep 17 00:00:00 2001
From: Renato Andreola <renato.andreola@imagos.it>
Date: Fri, 10 Apr 2009 12:32:29 +0200
Subject:     Nios2: do_boom_linux(): kernel gunzip input data integrity 
problem due to mi
 ssing cache flush

    Added instruction and data caches flush

    Signed-off-by: Renato Andreola <renato.andreola@imagos.it>
---
 lib_nios2/bootm.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c
index 53fd569..1e8034b 100644
--- a/lib_nios2/bootm.c
+++ b/lib_nios2/bootm.c
@@ -2,6 +2,9 @@
  * (C) Copyright 2003, Psyent Corporation <www.psyent.com>
  * Scott McNutt <smcnutt@psyent.com>
  *
+ * (C) Copyright 2009, Imagos sas <www.imagos.it>
+ * Renato Andreola <renato.andreola@imagos.it>
+ *
  * See file CREDITS for list of people who contributed to this
  * project.
  *
@@ -24,6 +27,7 @@
 #include <common.h>
 #include <command.h>
 #include <asm/byteorder.h>
+#include <asm/cache.h>
 
 int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t 
*images)
 {
@@ -31,7 +35,9 @@ int do_bootm_linux(int flag, int argc, char *argv[], 
bootm_headers_t *images)
 
     if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
         return 1;
-
+    /* flushes data and instruction caches before calling the kernel */
+    flush_dcache (0,CONFIG_SYS_DCACHE_SIZE );
+    flush_icache (0,CONFIG_SYS_ICACHE_SIZE);
     /* For now we assume the Microtronix linux ... which only
      * needs to be called ;-)
      */
-- 
1.5.5

[U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

[Wolfgang Denk]

Dear Scott,

In message <49DF39CD.9010202@imagos.it> you wrote:
>  From b75bd27f89ac6c105cebb6507cf082b6f5fffc7d Mon Sep 17 00:00:00 2001
> From: Renato Andreola <renato.andreola@imagos.it>
> Date: Fri, 10 Apr 2009 12:32:29 +0200
> Subject:     Nios2: do_boom_linux(): kernel gunzip input data integrity 
> problem due to mi
>  ssing cache flush
> 
>     Added instruction and data caches flush
> 
>     Signed-off-by: Renato Andreola <renato.andreola@imagos.it>
> ---
>  lib_nios2/bootm.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)

AFAICT this has neither been applied nor rejected yet.
Please check.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's an old proverb that says just about whatever you want it to.

[U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

[Renato Andreola]

 From caddbcecc99d7f96fdf7ca9c3d89ffac9cb999e1 Mon Sep 17 00:00:00 2001
From: Renato Andreola <renato.andreola@imagos.it>
Date: Thu, 6 Aug 2009 11:03:19 +0200
Subject:     Nios2: do_boom_linux(): kernel gunzip input data integrity 
problem due to mi
ssing cache flush

    Added instruction and data caches flush

    Signed-off-by: Renato Andreola <renato.andreola@imagos.it>

---
  lib_nios2/bootm.c |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c
index 53fd569..65bb4cb 100644
--- a/lib_nios2/bootm.c
+++ b/lib_nios2/bootm.c
@@ -24,6 +24,7 @@
  #include <common.h>
  #include <command.h>
  #include <asm/byteorder.h>
+#include <asm/cache.h>

  int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t 
*images)
  {
@@ -32,6 +33,10 @@ int do_bootm_linux(int flag, int argc, char *argv[], 
bootm_headers_t *images)
  	if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
  		return 1;

+	/* flushes data and instruction caches before calling the kernel */
+	flush_dcache (0,CONFIG_SYS_DCACHE_SIZE );
+	flush_icache (0,CONFIG_SYS_ICACHE_SIZE);
+
  	/* For now we assume the Microtronix linux ... which only
  	 * needs to be called ;-)
  	 */
-- 
1.5.5

[U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

[Wolfgang Denk]

Dear Renato Andreola,

In message <49DF39CD.9010202@imagos.it> you wrote:
>  From b75bd27f89ac6c105cebb6507cf082b6f5fffc7d Mon Sep 17 00:00:00 2001
> From: Renato Andreola <renato.andreola@imagos.it>
> Date: Fri, 10 Apr 2009 12:32:29 +0200
> Subject:     Nios2: do_boom_linux(): kernel gunzip input data integrity 
> problem due to mi
>  ssing cache flush
> 
>     Added instruction and data caches flush
> 
>     Signed-off-by: Renato Andreola <renato.andreola@imagos.it>
> ---
>  lib_nios2/bootm.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c
> index 53fd569..1e8034b 100644
> --- a/lib_nios2/bootm.c
> +++ b/lib_nios2/bootm.c
> @@ -2,6 +2,9 @@
>   * (C) Copyright 2003, Psyent Corporation <www.psyent.com>
>   * Scott McNutt <smcnutt@psyent.com>
>   *
> + * (C) Copyright 2009, Imagos sas <www.imagos.it>
> + * Renato Andreola <renato.andreola@imagos.it>
> + *

We are still waiting for you to resubmit this patch without adding a
Copyright note for just two lines of code.

Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In matters of principle, stand like a rock;  in  matters  of  taste,
swim with the current."                            - Thomas Jefferson

[U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

[Scott McNutt]

Wolfgang,

I checked on this again ... and missed it as well. This was resubmitted
on Thu, 6 Aug 2009. I'll add the resubmitted patch.

My apologies for any inconvenience.

Regards,
--Scott

Wolfgang Denk wrote:
> Dear Renato Andreola,
> 
> In message <49DF39CD.9010202@imagos.it> you wrote:
>>  From b75bd27f89ac6c105cebb6507cf082b6f5fffc7d Mon Sep 17 00:00:00 2001
>> From: Renato Andreola <renato.andreola@imagos.it>
>> Date: Fri, 10 Apr 2009 12:32:29 +0200
>> Subject:     Nios2: do_boom_linux(): kernel gunzip input data integrity 
>> problem due to mi
>>  ssing cache flush
>>
>>     Added instruction and data caches flush
>>
>>     Signed-off-by: Renato Andreola <renato.andreola@imagos.it>
>> ---
>>  lib_nios2/bootm.c |    8 +++++++-
>>  1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c
>> index 53fd569..1e8034b 100644
>> --- a/lib_nios2/bootm.c
>> +++ b/lib_nios2/bootm.c
>> @@ -2,6 +2,9 @@
>>   * (C) Copyright 2003, Psyent Corporation <www.psyent.com>
>>   * Scott McNutt <smcnutt@psyent.com>
>>   *
>> + * (C) Copyright 2009, Imagos sas <www.imagos.it>
>> + * Renato Andreola <renato.andreola@imagos.it>
>> + *
> 
> We are still waiting for you to resubmit this patch without adding a
> Copyright note for just two lines of code.
> 
> Thanks in advance.
> 
> Best regards,
> 
> Wolfgang Denk
>