From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] unused dhcp option?
Date: Thu, 06 Aug 2009 10:28:47 -0700 [thread overview]
Message-ID: <4A7B12CF.4090604@gmail.com> (raw)
In-Reply-To: <200908061322.44082.rgetz@blackfin.uclinux.org>
Hi Robin,
Robin Getz wrote:
> As far as I can tell - the dhcp_leasetime var is not accessed outside of the
> net/bootp.c file, and it isn't actually used anywhere, just written to - so
> it is not removed by --gc-sections. :(
>
> net/bootp.c:unsigned long dhcp_leasetime = 0;
>
> net/bootp.c: NetCopyLong (&dhcp_leasetime, (ulong *) (popt + 2));
>
> So, it should be declared as static, or removed completely -- which do you
> prefer? (for size - I would prefer punt).
>
> -Robin
>
Yeah, looks like it's not referenced anywhere. I say replace it with a
comment like so many other parts of the packet:
/* Ignore Lease Time Field*/
regards,
Ben
parent reply other threads:[~2009-08-06 17:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200908061322.44082.rgetz@blackfin.uclinux.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7B12CF.4090604@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox