From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Thu, 06 Aug 2009 10:28:47 -0700
Subject: [U-Boot] unused dhcp option?
In-Reply-To: <200908061322.44082.rgetz@blackfin.uclinux.org>
References: <200908061322.44082.rgetz@blackfin.uclinux.org>
Message-ID: <4A7B12CF.4090604@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Robin,

Robin Getz wrote:
> As far as I can tell - the dhcp_leasetime var is not accessed outside of the 
> net/bootp.c file, and it isn't actually used anywhere, just written to - so 
> it is not removed by --gc-sections. :(
>
> net/bootp.c:unsigned long dhcp_leasetime = 0;
>
> net/bootp.c:            NetCopyLong (&dhcp_leasetime, (ulong *) (popt + 2));
>
> So, it should be declared as static, or removed completely -- which do you 
> prefer? (for size - I would prefer punt).
>
> -Robin
>   
Yeah, looks like it's not referenced anywhere.  I say replace it with a 
comment like so many other parts of the packet:
/* Ignore Lease Time Field*/

regards,
Ben