public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/tftp.c: fix warning: pointer targets differ in signedness
Date: Mon, 10 Aug 2009 14:54:28 -0700	[thread overview]
Message-ID: <4A809714.6040208@gmail.com> (raw)
In-Reply-To: <1249891294-7647-1-git-send-email-wd@denx.de>

Wolfgang,

Wolfgang Denk wrote:
> tftp.c:294: warning: pointer targets in passing argument 1 of 'strlen'
> differ in signedness
>
> This was only visible for the utx8245 board which seems to have DEBUG
> enabled.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  net/tftp.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/tftp.c b/net/tftp.c
> index 74d9e42..fb98a34 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -291,7 +291,9 @@ TftpHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len)
>  		break;
>  
>  	case TFTP_OACK:
> -		debug("Got OACK: %s %s\n", pkt, pkt+strlen(pkt)+1);
> +		debug("Got OACK: %s %s\n",
> +			pkt,
> +			pkt + strlen((char *)pkt) + 1);
>  		TftpState = STATE_OACK;
>  		TftpServerPort = src;
>  		/*
>   
Applied to net repo.

thanks,
Ben

      reply	other threads:[~2009-08-10 21:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-10  8:01 [U-Boot] [PATCH] net/tftp.c: fix warning: pointer targets differ in signedness Wolfgang Denk
2009-08-10 21:54 ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A809714.6040208@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox