* [U-Boot] [PATCH] net/tftp.c: fix warning: pointer targets differ in signedness
@ 2009-08-10 8:01 Wolfgang Denk
2009-08-10 21:54 ` Ben Warren
0 siblings, 1 reply; 2+ messages in thread
From: Wolfgang Denk @ 2009-08-10 8:01 UTC (permalink / raw)
To: u-boot
tftp.c:294: warning: pointer targets in passing argument 1 of 'strlen'
differ in signedness
This was only visible for the utx8245 board which seems to have DEBUG
enabled.
Signed-off-by: Wolfgang Denk <wd@denx.de>
---
net/tftp.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/tftp.c b/net/tftp.c
index 74d9e42..fb98a34 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -291,7 +291,9 @@ TftpHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len)
break;
case TFTP_OACK:
- debug("Got OACK: %s %s\n", pkt, pkt+strlen(pkt)+1);
+ debug("Got OACK: %s %s\n",
+ pkt,
+ pkt + strlen((char *)pkt) + 1);
TftpState = STATE_OACK;
TftpServerPort = src;
/*
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] net/tftp.c: fix warning: pointer targets differ in signedness
2009-08-10 8:01 [U-Boot] [PATCH] net/tftp.c: fix warning: pointer targets differ in signedness Wolfgang Denk
@ 2009-08-10 21:54 ` Ben Warren
0 siblings, 0 replies; 2+ messages in thread
From: Ben Warren @ 2009-08-10 21:54 UTC (permalink / raw)
To: u-boot
Wolfgang,
Wolfgang Denk wrote:
> tftp.c:294: warning: pointer targets in passing argument 1 of 'strlen'
> differ in signedness
>
> This was only visible for the utx8245 board which seems to have DEBUG
> enabled.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
> net/tftp.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/tftp.c b/net/tftp.c
> index 74d9e42..fb98a34 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -291,7 +291,9 @@ TftpHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len)
> break;
>
> case TFTP_OACK:
> - debug("Got OACK: %s %s\n", pkt, pkt+strlen(pkt)+1);
> + debug("Got OACK: %s %s\n",
> + pkt,
> + pkt + strlen((char *)pkt) + 1);
> TftpState = STATE_OACK;
> TftpServerPort = src;
> /*
>
Applied to net repo.
thanks,
Ben
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-10 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-10 8:01 [U-Boot] [PATCH] net/tftp.c: fix warning: pointer targets differ in signedness Wolfgang Denk
2009-08-10 21:54 ` Ben Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox