public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] LIBFDT - changing command line
Date: Wed, 12 Aug 2009 08:21:17 +0200	[thread overview]
Message-ID: <4A825F5D.9030207@monstr.eu> (raw)
In-Reply-To: <4A81F16D.9070001@gmail.com>

Jerry Van Baren wrote:
> Hi Michal
> 
> Michal Simek wrote:
>> Hi All,
>>
>> I would like to use fdt for changing command line in DTB but
>> I found there is one problem if I have longer command line which contains
>> any spaces.
>> Below is my workflow.
>> If I understand correctly the problem is in
>> cmd_fdt.c:fdt_parse_prop:593-603.
>> It will be worth to add case for supporting
>> fdt set /chosen bootargs "console=ttyUL root=/dev/mtdblock0"
>> copy from first " to next "
>>
>> Or is it there any solution which I miss for this case?
>>
>> Thanks,
>> Michal
> 
> It is somewhat ugly, but the you can use "\" to escape the spaces:
>   fdt set /chosen bootargs console=ttyUL\ root=/dev/mtdblock0

Of course I tried it but simply not work.


U-Boot-mONStR> fdt list /chosen
chosen {
        bootargs = "console=ttyUL0,115200 highres=on root=/dev/mtdblock0";
        linux,stdout-path = "/plb at 0/serial at 84000000";
};
U-Boot-mONStR> fdt set /chosen bootargs console=ttyUL\ root=dev
U-Boot-mONStR> fdt list /chosen
chosen {
        bootargs = "root=dev";
        linux,stdout-path = "/plb at 0/serial at 84000000";
};
U-Boot-mONStR>

Can you tried it on your ppc?

Michal

> 
> I did this originally (IIRC) so that I wouldn't have to deal with
> handling quotes in the parsing (Are they there? Are they balanced?  What
> to do if not balanced?).  Add in a dash of lazy...


> 
> [snip]
> 
> Best regards,
> gvb


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

  reply	other threads:[~2009-08-12  6:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11 19:37 [U-Boot] LIBFDT - changing command line Michal Simek
2009-08-11 22:32 ` Jerry Van Baren
2009-08-12  6:21   ` Michal Simek [this message]
2009-08-13  2:10     ` Jerry Van Baren
2009-08-13  5:50       ` Wolfgang Denk
2009-08-13 12:24         ` Jerry Van Baren
2009-08-13 12:46           ` Wolfgang Denk
2009-08-13  9:23       ` Michal Simek
2009-08-13  9:29         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A825F5D.9030207@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox