* [U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache @ 2009-08-12 15:42 Tom Rix 2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix 0 siblings, 1 reply; 9+ messages in thread From: Tom Rix @ 2009-08-12 15:42 UTC (permalink / raw) To: u-boot > Dear Tom Rix, > In message <1246898879-6567-2-git-send-email-Tom.Rix@windriver.com> you wrote: > > --===============0808050101== > > > > Since there is only one version of flushing the dcache for > > arm_cortex8, rename v7_flush_dcache_all to the the generic > > name flush_dcache. Because the function is intended for > > only omap3 boards, move the function to the new file > > cache_flush.S. <snip> > Sorry, this patch does not apply any more: <snip> > Patch failed at 0001. > Please rebase and resubmit (also patch 2/2). > Best regards, > Wolfgang Denk Wolfgang, I have rebased the patch the to the u-boot master branch. It includes the moving of omap3 cache routines to cache.S that Jean requested and renaming flush_dache to invalidate_dcache that Richard requested. Tom ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 15:42 [U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix @ 2009-08-12 15:42 ` Tom Rix 2009-08-12 16:35 ` Dirk Behme ` (3 more replies) 0 siblings, 4 replies; 9+ messages in thread From: Tom Rix @ 2009-08-12 15:42 UTC (permalink / raw) To: u-boot v7_flush_dcache_all, because it depends on omap ROM code is not generic. Rename the function to 'invalidate_dcache' and move it to the omap cpu directory. Collect the other omap cache routines l2_cache_enable and l2_cache_disable with invalide_dcache into cache.S. This means removing the old cache.c file that contained l2_cache_enable and l2_cache_disable. The conversion from cache.c to cache.S was done most through disassembling the uboot binary. The only significant change was to change the comparision for the return of get_cpu_rev from cmp r0, #0 beq earlier_than_label Which was lost information to cmp r0, #CPU_3XX_ES20 blt earlier_than_label The paths through the enable routine were verified by adding an infinite loop and seeing the hang. Then removing the infinite loop and seeing it continue. The disable routine is similar enough that it was not tested with this method. Run tested by cold booting from nand on beagle and zoom1. Compile tested on MAKEALL arm. Signed-off-by: Tom Rix <Tom.Rix@windriver.com> --- cpu/arm_cortexa8/cpu.c | 2 +- cpu/arm_cortexa8/omap3/Makefile | 2 +- cpu/arm_cortexa8/omap3/board.c | 2 +- cpu/arm_cortexa8/omap3/cache.S | 191 ++++++++++++++++++++++++++++++++ cpu/arm_cortexa8/omap3/cache.c | 95 ---------------- cpu/arm_cortexa8/start.S | 85 -------------- include/asm-arm/arch-omap3/omap3.h | 2 + include/asm-arm/arch-omap3/sys_proto.h | 2 +- 8 files changed, 197 insertions(+), 184 deletions(-) create mode 100644 cpu/arm_cortexa8/omap3/cache.S delete mode 100644 cpu/arm_cortexa8/omap3/cache.c diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c index 5a5981e..a01e0d6 100644 --- a/cpu/arm_cortexa8/cpu.c +++ b/cpu/arm_cortexa8/cpu.c @@ -64,7 +64,7 @@ int cleanup_before_linux(void) /* turn off L2 cache */ l2_cache_disable(); /* invalidate L2 cache also */ - v7_flush_dcache_all(get_device_type()); + invalidate_dcache(get_device_type()); #endif i = 0; /* mem barrier to sync up things */ diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile index eef165c..136b163 100644 --- a/cpu/arm_cortexa8/omap3/Makefile +++ b/cpu/arm_cortexa8/omap3/Makefile @@ -26,10 +26,10 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(SOC).a SOBJS := lowlevel_init.o +SOBJS += cache.o SOBJS += reset.o COBJS += board.o -COBJS += cache.o COBJS += clock.o COBJS += gpio.o COBJS += mem.o diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c index 2337287..43262e7 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -201,7 +201,7 @@ void s_init(void) * Right now flushing at low MPU speed. * Need to move after clock init */ - v7_flush_dcache_all(get_device_type()); + invalidate_dcache(get_device_type()); #ifndef CONFIG_ICACHE_OFF icache_enable(); #endif diff --git a/cpu/arm_cortexa8/omap3/cache.S b/cpu/arm_cortexa8/omap3/cache.S new file mode 100644 index 0000000..0f63815 --- /dev/null +++ b/cpu/arm_cortexa8/omap3/cache.S @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2009 Wind River Systems, Inc. + * Tom Rix <Tom.Rix@windriver.com> + * + * This file is based on and replaces the existing cache.c file + * The copyrights for the cache.c file are: + * + * (C) Copyright 2008 Texas Insturments + * + * (C) Copyright 2002 + * Sysgo Real-Time Solutions, GmbH <www.elinos.com> + * Marius Groeger <mgroeger@sysgo.de> + * + * (C) Copyright 2002 + * Gary Jennejohn, DENX Software Engineering, <gj@denx.de> + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include <asm/arch/omap3.h> + +/* + * omap3 cache code + */ + +.align 5 +.global invalidate_dcache +.global l2_cache_enable +.global l2_cache_disable + +/* + * invalidate_dcache() + * + * Invalidate the whole D-cache. + * + * Corrupted registers: r0-r5, r7, r9-r11 + * + * - mm - mm_struct describing address space + */ +invalidate_dcache: + stmfd r13!, {r0 - r5, r7, r9 - r12, r14} + + mov r7, r0 @ take a backup of device type + cmp r0, #0x3 @ check if the device type is + @ GP + moveq r12, #0x1 @ set up to invalide L2 +smi: .word 0x01600070 @ Call SMI monitor (smieq) + cmp r7, #0x3 @ compare again in case its + @ lost + beq finished_inval @ if GP device, inval done + @ above + + mrc p15, 1, r0, c0, c0, 1 @ read clidr + ands r3, r0, #0x7000000 @ extract loc from clidr + mov r3, r3, lsr #23 @ left align loc bit field + beq finished_inval @ if loc is 0, then no need to + @ clean + mov r10, #0 @ start clean at cache level 0 +inval_loop1: + add r2, r10, r10, lsr #1 @ work out 3x current cache + @ level + mov r1, r0, lsr r2 @ extract cache type bits from + @ clidr + and r1, r1, #7 @ mask of the bits for current + @ cache only + cmp r1, #2 @ see what cache we have at + @ this level + blt skip_inval @ skip if no cache, or just + @ i-cache + mcr p15, 2, r10, c0, c0, 0 @ select current cache level + @ in cssr + mov r2, #0 @ operand for mcr SBZ + mcr p15, 0, r2, c7, c5, 4 @ flush prefetch buffer to + @ sych the new cssr&csidr, + @ with armv7 this is 'isb', + @ but we compile with armv5 + mrc p15, 1, r1, c0, c0, 0 @ read the new csidr + and r2, r1, #7 @ extract the length of the + @ cache lines + add r2, r2, #4 @ add 4 (line length offset) + ldr r4, =0x3ff + ands r4, r4, r1, lsr #3 @ find maximum number on the + @ way size + clz r5, r4 @ find bit position of way + @ size increment + ldr r7, =0x7fff + ands r7, r7, r1, lsr #13 @ extract max number of the + @ index size +inval_loop2: + mov r9, r4 @ create working copy of max + @ way size +inval_loop3: + orr r11, r10, r9, lsl r5 @ factor way and cache number + @ into r11 + orr r11, r11, r7, lsl r2 @ factor index number into r11 + mcr p15, 0, r11, c7, c6, 2 @ invalidate by set/way + subs r9, r9, #1 @ decrement the way + bge inval_loop3 + subs r7, r7, #1 @ decrement the index + bge inval_loop2 +skip_inval: + add r10, r10, #2 @ increment cache number + cmp r3, r10 + bgt inval_loop1 +finished_inval: + mov r10, #0 @ swith back to cache level 0 + mcr p15, 2, r10, c0, c0, 0 @ select current cache level + @ in cssr + mcr p15, 0, r10, c7, c5, 4 @ flush prefetch buffer, + @ with armv7 this is 'isb', + @ but we compile with armv5 + + ldmfd r13!, {r0 - r5, r7, r9 - r12, pc} + + +l2_cache_enable: + push {r0, r1, r2, lr} + @ ES2 onwards we can disable/enable L2 ourselves + bl get_cpu_rev + cmp r0, #CPU_3XX_ES20 + blt l2_cache_disable_EARLIER_THAN_ES2 + mrc 15, 0, r3, cr1, cr0, 1 + orr r3, r3, #2 + mcr 15, 0, r3, cr1, cr0, 1 + b l2_cache_enable_END +l2_cache_enable_EARLIER_THAN_ES2: + @ Save r0, r12 and restore them after usage + mov r3, ip + str r3, [sp, #4] + mov r3, r0 + @ + @ GP Device ROM code API usage here + @ r12 = AUXCR Write function and r0 value + @ + mov ip, #3 + mrc 15, 0, r0, cr1, cr0, 1 + orr r0, r0, #2 + @ SMI instruction to call ROM Code API + .word 0xe1600070 + mov r0, r3 + mov ip, r3 + str r3, [sp, #4] +l2_cache_enable_END: + pop {r1, r2, r3, pc} + + +l2_cache_disable: + push {r0, r1, r2, lr} + @ ES2 onwards we can disable/enable L2 ourselves + bl get_cpu_rev + cmp r0, #CPU_3XX_ES20 + blt l2_cache_disable_EARLIER_THAN_ES2 + mrc 15, 0, r3, cr1, cr0, 1 + bic r3, r3, #2 + mcr 15, 0, r3, cr1, cr0, 1 + b l2_cache_disable_END +l2_cache_disable_EARLIER_THAN_ES2: + @ Save r0, r12 and restore them after usage + mov r3, ip + str r3, [sp, #4] + mov r3, r0 + @ + @ GP Device ROM code API usage here + @ r12 = AUXCR Write function and r0 value + @ + mov ip, #3 + mrc 15, 0, r0, cr1, cr0, 1 + bic r0, r0, #2 + @ SMI instruction to call ROM Code API + .word 0xe1600070 + mov r0, r3 + mov ip, r3 + str r3, [sp, #4] +l2_cache_disable_END: + pop {r1, r2, r3, pc} diff --git a/cpu/arm_cortexa8/omap3/cache.c b/cpu/arm_cortexa8/omap3/cache.c deleted file mode 100644 index 0d5b444..0000000 --- a/cpu/arm_cortexa8/omap3/cache.c +++ /dev/null @@ -1,95 +0,0 @@ -/* - * (C) Copyright 2008 Texas Insturments - * - * (C) Copyright 2002 - * Sysgo Real-Time Solutions, GmbH <www.elinos.com> - * Marius Groeger <mgroeger@sysgo.de> - * - * (C) Copyright 2002 - * Gary Jennejohn, DENX Software Engineering, <gj@denx.de> - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, - * MA 02111-1307 USA - */ - -/* - * omap3 L2 cache code - */ - -#include <common.h> -#include <asm/arch/sys_proto.h> -#include <asm/cache.h> - -void l2_cache_enable(void) -{ - unsigned long i; - volatile unsigned int j; - - /* ES2 onwards we can disable/enable L2 ourselves */ - if (get_cpu_rev() >= CPU_3XX_ES20) { - __asm__ __volatile__("mrc p15, 0, %0, c1, c0, 1":"=r"(i)); - __asm__ __volatile__("orr %0, %0, #0x2":"=r"(i)); - __asm__ __volatile__("mcr p15, 0, %0, c1, c0, 1":"=r"(i)); - } else { - /* Save r0, r12 and restore them after usage */ - __asm__ __volatile__("mov %0, r12":"=r"(j)); - __asm__ __volatile__("mov %0, r0":"=r"(i)); - - /* - * GP Device ROM code API usage here - * r12 = AUXCR Write function and r0 value - */ - __asm__ __volatile__("mov r12, #0x3"); - __asm__ __volatile__("mrc p15, 0, r0, c1, c0, 1"); - __asm__ __volatile__("orr r0, r0, #0x2"); - /* SMI instruction to call ROM Code API */ - __asm__ __volatile__(".word 0xE1600070"); - __asm__ __volatile__("mov r0, %0":"=r"(i)); - __asm__ __volatile__("mov r12, %0":"=r"(j)); - } - -} - -void l2_cache_disable(void) -{ - unsigned long i; - volatile unsigned int j; - - /* ES2 onwards we can disable/enable L2 ourselves */ - if (get_cpu_rev() >= CPU_3XX_ES20) { - __asm__ __volatile__("mrc p15, 0, %0, c1, c0, 1":"=r"(i)); - __asm__ __volatile__("bic %0, %0, #0x2":"=r"(i)); - __asm__ __volatile__("mcr p15, 0, %0, c1, c0, 1":"=r"(i)); - } else { - /* Save r0, r12 and restore them after usage */ - __asm__ __volatile__("mov %0, r12":"=r"(j)); - __asm__ __volatile__("mov %0, r0":"=r"(i)); - - /* - * GP Device ROM code API usage here - * r12 = AUXCR Write function and r0 value - */ - __asm__ __volatile__("mov r12, #0x3"); - __asm__ __volatile__("mrc p15, 0, r0, c1, c0, 1"); - __asm__ __volatile__("bic r0, r0, #0x2"); - /* SMI instruction to call ROM Code API */ - __asm__ __volatile__(".word 0xE1600070"); - __asm__ __volatile__("mov r0, %0":"=r"(i)); - __asm__ __volatile__("mov r12, %0":"=r"(j)); - } -} diff --git a/cpu/arm_cortexa8/start.S b/cpu/arm_cortexa8/start.S index 6bd6552..14a9bd3 100644 --- a/cpu/arm_cortexa8/start.S +++ b/cpu/arm_cortexa8/start.S @@ -415,88 +415,3 @@ fiq: #endif -/* - * v7_flush_dcache_all() - * - * Flush the whole D-cache. - * - * Corrupted registers: r0-r5, r7, r9-r11 - * - * - mm - mm_struct describing address space - */ - .align 5 -.global v7_flush_dcache_all -v7_flush_dcache_all: - stmfd r13!, {r0 - r5, r7, r9 - r12, r14} - - mov r7, r0 @ take a backup of device type - cmp r0, #0x3 @ check if the device type is - @ GP - moveq r12, #0x1 @ set up to invalide L2 -smi: .word 0x01600070 @ Call SMI monitor (smieq) - cmp r7, #0x3 @ compare again in case its - @ lost - beq finished_inval @ if GP device, inval done - @ above - - mrc p15, 1, r0, c0, c0, 1 @ read clidr - ands r3, r0, #0x7000000 @ extract loc from clidr - mov r3, r3, lsr #23 @ left align loc bit field - beq finished_inval @ if loc is 0, then no need to - @ clean - mov r10, #0 @ start clean at cache level 0 -inval_loop1: - add r2, r10, r10, lsr #1 @ work out 3x current cache - @ level - mov r1, r0, lsr r2 @ extract cache type bits from - @ clidr - and r1, r1, #7 @ mask of the bits for current - @ cache only - cmp r1, #2 @ see what cache we have at - @ this level - blt skip_inval @ skip if no cache, or just - @ i-cache - mcr p15, 2, r10, c0, c0, 0 @ select current cache level - @ in cssr - mov r2, #0 @ operand for mcr SBZ - mcr p15, 0, r2, c7, c5, 4 @ flush prefetch buffer to - @ sych the new cssr&csidr, - @ with armv7 this is 'isb', - @ but we compile with armv5 - mrc p15, 1, r1, c0, c0, 0 @ read the new csidr - and r2, r1, #7 @ extract the length of the - @ cache lines - add r2, r2, #4 @ add 4 (line length offset) - ldr r4, =0x3ff - ands r4, r4, r1, lsr #3 @ find maximum number on the - @ way size - clz r5, r4 @ find bit position of way - @ size increment - ldr r7, =0x7fff - ands r7, r7, r1, lsr #13 @ extract max number of the - @ index size -inval_loop2: - mov r9, r4 @ create working copy of max - @ way size -inval_loop3: - orr r11, r10, r9, lsl r5 @ factor way and cache number - @ into r11 - orr r11, r11, r7, lsl r2 @ factor index number into r11 - mcr p15, 0, r11, c7, c6, 2 @ invalidate by set/way - subs r9, r9, #1 @ decrement the way - bge inval_loop3 - subs r7, r7, #1 @ decrement the index - bge inval_loop2 -skip_inval: - add r10, r10, #2 @ increment cache number - cmp r3, r10 - bgt inval_loop1 -finished_inval: - mov r10, #0 @ swith back to cache level 0 - mcr p15, 2, r10, c0, c0, 0 @ select current cache level - @ in cssr - mcr p15, 0, r10, c7, c5, 4 @ flush prefetch buffer, - @ with armv7 this is 'isb', - @ but we compile with armv5 - - ldmfd r13!, {r0 - r5, r7, r9 - r12, pc} diff --git a/include/asm-arm/arch-omap3/omap3.h b/include/asm-arm/arch-omap3/omap3.h index 6459d99..12815f6 100644 --- a/include/asm-arm/arch-omap3/omap3.h +++ b/include/asm-arm/arch-omap3/omap3.h @@ -168,6 +168,8 @@ struct gpio { * ES1 = rev 0 * * ES2 onwards, the value maps to contents of IDCODE register [31:28]. + * + * Note : CPU_3XX_ES20 is used in cache.S. Please review before changing. */ #define CPU_3XX_ES10 0 #define CPU_3XX_ES20 1 diff --git a/include/asm-arm/arch-omap3/sys_proto.h b/include/asm-arm/arch-omap3/sys_proto.h index 7361d08..2246f80 100644 --- a/include/asm-arm/arch-omap3/sys_proto.h +++ b/include/asm-arm/arch-omap3/sys_proto.h @@ -55,7 +55,7 @@ void secureworld_exit(void); void setup_auxcr(void); void try_unlock_memory(void); u32 get_boot_type(void); -void v7_flush_dcache_all(u32); +void invalidate_dcache(u32); void sr32(void *, u32, u32, u32); u32 wait_on_value(u32, u32, void *, u32); void sdelay(unsigned long); -- 1.6.0.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix @ 2009-08-12 16:35 ` Dirk Behme 2009-08-12 21:13 ` Jean-Christophe PLAGNIOL-VILLARD ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Dirk Behme @ 2009-08-12 16:35 UTC (permalink / raw) To: u-boot Tom Rix wrote: > v7_flush_dcache_all, because it depends on omap ROM code is not > generic. Rename the function to 'invalidate_dcache' and move it > to the omap cpu directory. > > Collect the other omap cache routines l2_cache_enable and > l2_cache_disable with invalide_dcache into cache.S. This > means removing the old cache.c file that contained l2_cache_enable > and l2_cache_disable. > > The conversion from cache.c to cache.S was done most through > disassembling the uboot binary. The only significant change was > to change the comparision for the return of get_cpu_rev from > > cmp r0, #0 > beq earlier_than_label > > Which was lost information to > > cmp r0, #CPU_3XX_ES20 > blt earlier_than_label > > The paths through the enable routine were verified by > adding an infinite loop and seeing the hang. Then > removing the infinite loop and seeing it continue. > > The disable routine is similar enough that it was not > tested with this method. > > Run tested by cold booting from nand on beagle and zoom1. > Compile tested on MAKEALL arm. Boot tested from SD card on BeagleBoard. > Signed-off-by: Tom Rix <Tom.Rix@windriver.com> Acked-by: Dirk Behme <dirk.behme@googlemail.com> > --- > cpu/arm_cortexa8/cpu.c | 2 +- > cpu/arm_cortexa8/omap3/Makefile | 2 +- > cpu/arm_cortexa8/omap3/board.c | 2 +- > cpu/arm_cortexa8/omap3/cache.S | 191 ++++++++++++++++++++++++++++++++ > cpu/arm_cortexa8/omap3/cache.c | 95 ---------------- > cpu/arm_cortexa8/start.S | 85 -------------- > include/asm-arm/arch-omap3/omap3.h | 2 + > include/asm-arm/arch-omap3/sys_proto.h | 2 +- > 8 files changed, 197 insertions(+), 184 deletions(-) > create mode 100644 cpu/arm_cortexa8/omap3/cache.S > delete mode 100644 cpu/arm_cortexa8/omap3/cache.c > > diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c > index 5a5981e..a01e0d6 100644 > --- a/cpu/arm_cortexa8/cpu.c > +++ b/cpu/arm_cortexa8/cpu.c > @@ -64,7 +64,7 @@ int cleanup_before_linux(void) > /* turn off L2 cache */ > l2_cache_disable(); > /* invalidate L2 cache also */ > - v7_flush_dcache_all(get_device_type()); > + invalidate_dcache(get_device_type()); > #endif > i = 0; > /* mem barrier to sync up things */ > diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile > index eef165c..136b163 100644 > --- a/cpu/arm_cortexa8/omap3/Makefile > +++ b/cpu/arm_cortexa8/omap3/Makefile > @@ -26,10 +26,10 @@ include $(TOPDIR)/config.mk > LIB = $(obj)lib$(SOC).a > > SOBJS := lowlevel_init.o > +SOBJS += cache.o > SOBJS += reset.o > > COBJS += board.o > -COBJS += cache.o > COBJS += clock.o > COBJS += gpio.o > COBJS += mem.o > diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c > index 2337287..43262e7 100644 > --- a/cpu/arm_cortexa8/omap3/board.c > +++ b/cpu/arm_cortexa8/omap3/board.c > @@ -201,7 +201,7 @@ void s_init(void) > * Right now flushing at low MPU speed. > * Need to move after clock init > */ > - v7_flush_dcache_all(get_device_type()); > + invalidate_dcache(get_device_type()); > #ifndef CONFIG_ICACHE_OFF > icache_enable(); > #endif > diff --git a/cpu/arm_cortexa8/omap3/cache.S b/cpu/arm_cortexa8/omap3/cache.S > new file mode 100644 > index 0000000..0f63815 > --- /dev/null > +++ b/cpu/arm_cortexa8/omap3/cache.S > @@ -0,0 +1,191 @@ > +/* > + * Copyright (c) 2009 Wind River Systems, Inc. > + * Tom Rix <Tom.Rix@windriver.com> > + * > + * This file is based on and replaces the existing cache.c file > + * The copyrights for the cache.c file are: > + * > + * (C) Copyright 2008 Texas Insturments > + * > + * (C) Copyright 2002 > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com> > + * Marius Groeger <mgroeger@sysgo.de> > + * > + * (C) Copyright 2002 > + * Gary Jennejohn, DENX Software Engineering, <gj@denx.de> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > + * MA 02111-1307 USA > + */ > + > +#include <asm/arch/omap3.h> > + > +/* > + * omap3 cache code > + */ > + > +.align 5 > +.global invalidate_dcache > +.global l2_cache_enable > +.global l2_cache_disable > + > +/* > + * invalidate_dcache() > + * > + * Invalidate the whole D-cache. > + * > + * Corrupted registers: r0-r5, r7, r9-r11 > + * > + * - mm - mm_struct describing address space > + */ > +invalidate_dcache: > + stmfd r13!, {r0 - r5, r7, r9 - r12, r14} > + > + mov r7, r0 @ take a backup of device type > + cmp r0, #0x3 @ check if the device type is > + @ GP > + moveq r12, #0x1 @ set up to invalide L2 > +smi: .word 0x01600070 @ Call SMI monitor (smieq) > + cmp r7, #0x3 @ compare again in case its > + @ lost > + beq finished_inval @ if GP device, inval done > + @ above > + > + mrc p15, 1, r0, c0, c0, 1 @ read clidr > + ands r3, r0, #0x7000000 @ extract loc from clidr > + mov r3, r3, lsr #23 @ left align loc bit field > + beq finished_inval @ if loc is 0, then no need to > + @ clean > + mov r10, #0 @ start clean at cache level 0 > +inval_loop1: > + add r2, r10, r10, lsr #1 @ work out 3x current cache > + @ level > + mov r1, r0, lsr r2 @ extract cache type bits from > + @ clidr > + and r1, r1, #7 @ mask of the bits for current > + @ cache only > + cmp r1, #2 @ see what cache we have at > + @ this level > + blt skip_inval @ skip if no cache, or just > + @ i-cache > + mcr p15, 2, r10, c0, c0, 0 @ select current cache level > + @ in cssr > + mov r2, #0 @ operand for mcr SBZ > + mcr p15, 0, r2, c7, c5, 4 @ flush prefetch buffer to > + @ sych the new cssr&csidr, > + @ with armv7 this is 'isb', > + @ but we compile with armv5 > + mrc p15, 1, r1, c0, c0, 0 @ read the new csidr > + and r2, r1, #7 @ extract the length of the > + @ cache lines > + add r2, r2, #4 @ add 4 (line length offset) > + ldr r4, =0x3ff > + ands r4, r4, r1, lsr #3 @ find maximum number on the > + @ way size > + clz r5, r4 @ find bit position of way > + @ size increment > + ldr r7, =0x7fff > + ands r7, r7, r1, lsr #13 @ extract max number of the > + @ index size > +inval_loop2: > + mov r9, r4 @ create working copy of max > + @ way size > +inval_loop3: > + orr r11, r10, r9, lsl r5 @ factor way and cache number > + @ into r11 > + orr r11, r11, r7, lsl r2 @ factor index number into r11 > + mcr p15, 0, r11, c7, c6, 2 @ invalidate by set/way > + subs r9, r9, #1 @ decrement the way > + bge inval_loop3 > + subs r7, r7, #1 @ decrement the index > + bge inval_loop2 > +skip_inval: > + add r10, r10, #2 @ increment cache number > + cmp r3, r10 > + bgt inval_loop1 > +finished_inval: > + mov r10, #0 @ swith back to cache level 0 > + mcr p15, 2, r10, c0, c0, 0 @ select current cache level > + @ in cssr > + mcr p15, 0, r10, c7, c5, 4 @ flush prefetch buffer, > + @ with armv7 this is 'isb', > + @ but we compile with armv5 > + > + ldmfd r13!, {r0 - r5, r7, r9 - r12, pc} > + > + > +l2_cache_enable: > + push {r0, r1, r2, lr} > + @ ES2 onwards we can disable/enable L2 ourselves > + bl get_cpu_rev > + cmp r0, #CPU_3XX_ES20 > + blt l2_cache_disable_EARLIER_THAN_ES2 > + mrc 15, 0, r3, cr1, cr0, 1 > + orr r3, r3, #2 > + mcr 15, 0, r3, cr1, cr0, 1 > + b l2_cache_enable_END > +l2_cache_enable_EARLIER_THAN_ES2: > + @ Save r0, r12 and restore them after usage > + mov r3, ip > + str r3, [sp, #4] > + mov r3, r0 > + @ > + @ GP Device ROM code API usage here > + @ r12 = AUXCR Write function and r0 value > + @ > + mov ip, #3 > + mrc 15, 0, r0, cr1, cr0, 1 > + orr r0, r0, #2 > + @ SMI instruction to call ROM Code API > + .word 0xe1600070 > + mov r0, r3 > + mov ip, r3 > + str r3, [sp, #4] > +l2_cache_enable_END: > + pop {r1, r2, r3, pc} > + > + > +l2_cache_disable: > + push {r0, r1, r2, lr} > + @ ES2 onwards we can disable/enable L2 ourselves > + bl get_cpu_rev > + cmp r0, #CPU_3XX_ES20 > + blt l2_cache_disable_EARLIER_THAN_ES2 > + mrc 15, 0, r3, cr1, cr0, 1 > + bic r3, r3, #2 > + mcr 15, 0, r3, cr1, cr0, 1 > + b l2_cache_disable_END > +l2_cache_disable_EARLIER_THAN_ES2: > + @ Save r0, r12 and restore them after usage > + mov r3, ip > + str r3, [sp, #4] > + mov r3, r0 > + @ > + @ GP Device ROM code API usage here > + @ r12 = AUXCR Write function and r0 value > + @ > + mov ip, #3 > + mrc 15, 0, r0, cr1, cr0, 1 > + bic r0, r0, #2 > + @ SMI instruction to call ROM Code API > + .word 0xe1600070 > + mov r0, r3 > + mov ip, r3 > + str r3, [sp, #4] > +l2_cache_disable_END: > + pop {r1, r2, r3, pc} > diff --git a/cpu/arm_cortexa8/omap3/cache.c b/cpu/arm_cortexa8/omap3/cache.c > deleted file mode 100644 > index 0d5b444..0000000 > --- a/cpu/arm_cortexa8/omap3/cache.c > +++ /dev/null > @@ -1,95 +0,0 @@ > -/* > - * (C) Copyright 2008 Texas Insturments > - * > - * (C) Copyright 2002 > - * Sysgo Real-Time Solutions, GmbH <www.elinos.com> > - * Marius Groeger <mgroeger@sysgo.de> > - * > - * (C) Copyright 2002 > - * Gary Jennejohn, DENX Software Engineering, <gj@denx.de> > - * > - * See file CREDITS for list of people who contributed to this > - * project. > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public License as > - * published by the Free Software Foundation; either version 2 of > - * the License, or (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > - * MA 02111-1307 USA > - */ > - > -/* > - * omap3 L2 cache code > - */ > - > -#include <common.h> > -#include <asm/arch/sys_proto.h> > -#include <asm/cache.h> > - > -void l2_cache_enable(void) > -{ > - unsigned long i; > - volatile unsigned int j; > - > - /* ES2 onwards we can disable/enable L2 ourselves */ > - if (get_cpu_rev() >= CPU_3XX_ES20) { > - __asm__ __volatile__("mrc p15, 0, %0, c1, c0, 1":"=r"(i)); > - __asm__ __volatile__("orr %0, %0, #0x2":"=r"(i)); > - __asm__ __volatile__("mcr p15, 0, %0, c1, c0, 1":"=r"(i)); > - } else { > - /* Save r0, r12 and restore them after usage */ > - __asm__ __volatile__("mov %0, r12":"=r"(j)); > - __asm__ __volatile__("mov %0, r0":"=r"(i)); > - > - /* > - * GP Device ROM code API usage here > - * r12 = AUXCR Write function and r0 value > - */ > - __asm__ __volatile__("mov r12, #0x3"); > - __asm__ __volatile__("mrc p15, 0, r0, c1, c0, 1"); > - __asm__ __volatile__("orr r0, r0, #0x2"); > - /* SMI instruction to call ROM Code API */ > - __asm__ __volatile__(".word 0xE1600070"); > - __asm__ __volatile__("mov r0, %0":"=r"(i)); > - __asm__ __volatile__("mov r12, %0":"=r"(j)); > - } > - > -} > - > -void l2_cache_disable(void) > -{ > - unsigned long i; > - volatile unsigned int j; > - > - /* ES2 onwards we can disable/enable L2 ourselves */ > - if (get_cpu_rev() >= CPU_3XX_ES20) { > - __asm__ __volatile__("mrc p15, 0, %0, c1, c0, 1":"=r"(i)); > - __asm__ __volatile__("bic %0, %0, #0x2":"=r"(i)); > - __asm__ __volatile__("mcr p15, 0, %0, c1, c0, 1":"=r"(i)); > - } else { > - /* Save r0, r12 and restore them after usage */ > - __asm__ __volatile__("mov %0, r12":"=r"(j)); > - __asm__ __volatile__("mov %0, r0":"=r"(i)); > - > - /* > - * GP Device ROM code API usage here > - * r12 = AUXCR Write function and r0 value > - */ > - __asm__ __volatile__("mov r12, #0x3"); > - __asm__ __volatile__("mrc p15, 0, r0, c1, c0, 1"); > - __asm__ __volatile__("bic r0, r0, #0x2"); > - /* SMI instruction to call ROM Code API */ > - __asm__ __volatile__(".word 0xE1600070"); > - __asm__ __volatile__("mov r0, %0":"=r"(i)); > - __asm__ __volatile__("mov r12, %0":"=r"(j)); > - } > -} > diff --git a/cpu/arm_cortexa8/start.S b/cpu/arm_cortexa8/start.S > index 6bd6552..14a9bd3 100644 > --- a/cpu/arm_cortexa8/start.S > +++ b/cpu/arm_cortexa8/start.S > @@ -415,88 +415,3 @@ fiq: > > #endif > > -/* > - * v7_flush_dcache_all() > - * > - * Flush the whole D-cache. > - * > - * Corrupted registers: r0-r5, r7, r9-r11 > - * > - * - mm - mm_struct describing address space > - */ > - .align 5 > -.global v7_flush_dcache_all > -v7_flush_dcache_all: > - stmfd r13!, {r0 - r5, r7, r9 - r12, r14} > - > - mov r7, r0 @ take a backup of device type > - cmp r0, #0x3 @ check if the device type is > - @ GP > - moveq r12, #0x1 @ set up to invalide L2 > -smi: .word 0x01600070 @ Call SMI monitor (smieq) > - cmp r7, #0x3 @ compare again in case its > - @ lost > - beq finished_inval @ if GP device, inval done > - @ above > - > - mrc p15, 1, r0, c0, c0, 1 @ read clidr > - ands r3, r0, #0x7000000 @ extract loc from clidr > - mov r3, r3, lsr #23 @ left align loc bit field > - beq finished_inval @ if loc is 0, then no need to > - @ clean > - mov r10, #0 @ start clean at cache level 0 > -inval_loop1: > - add r2, r10, r10, lsr #1 @ work out 3x current cache > - @ level > - mov r1, r0, lsr r2 @ extract cache type bits from > - @ clidr > - and r1, r1, #7 @ mask of the bits for current > - @ cache only > - cmp r1, #2 @ see what cache we have at > - @ this level > - blt skip_inval @ skip if no cache, or just > - @ i-cache > - mcr p15, 2, r10, c0, c0, 0 @ select current cache level > - @ in cssr > - mov r2, #0 @ operand for mcr SBZ > - mcr p15, 0, r2, c7, c5, 4 @ flush prefetch buffer to > - @ sych the new cssr&csidr, > - @ with armv7 this is 'isb', > - @ but we compile with armv5 > - mrc p15, 1, r1, c0, c0, 0 @ read the new csidr > - and r2, r1, #7 @ extract the length of the > - @ cache lines > - add r2, r2, #4 @ add 4 (line length offset) > - ldr r4, =0x3ff > - ands r4, r4, r1, lsr #3 @ find maximum number on the > - @ way size > - clz r5, r4 @ find bit position of way > - @ size increment > - ldr r7, =0x7fff > - ands r7, r7, r1, lsr #13 @ extract max number of the > - @ index size > -inval_loop2: > - mov r9, r4 @ create working copy of max > - @ way size > -inval_loop3: > - orr r11, r10, r9, lsl r5 @ factor way and cache number > - @ into r11 > - orr r11, r11, r7, lsl r2 @ factor index number into r11 > - mcr p15, 0, r11, c7, c6, 2 @ invalidate by set/way > - subs r9, r9, #1 @ decrement the way > - bge inval_loop3 > - subs r7, r7, #1 @ decrement the index > - bge inval_loop2 > -skip_inval: > - add r10, r10, #2 @ increment cache number > - cmp r3, r10 > - bgt inval_loop1 > -finished_inval: > - mov r10, #0 @ swith back to cache level 0 > - mcr p15, 2, r10, c0, c0, 0 @ select current cache level > - @ in cssr > - mcr p15, 0, r10, c7, c5, 4 @ flush prefetch buffer, > - @ with armv7 this is 'isb', > - @ but we compile with armv5 > - > - ldmfd r13!, {r0 - r5, r7, r9 - r12, pc} > diff --git a/include/asm-arm/arch-omap3/omap3.h b/include/asm-arm/arch-omap3/omap3.h > index 6459d99..12815f6 100644 > --- a/include/asm-arm/arch-omap3/omap3.h > +++ b/include/asm-arm/arch-omap3/omap3.h > @@ -168,6 +168,8 @@ struct gpio { > * ES1 = rev 0 > * > * ES2 onwards, the value maps to contents of IDCODE register [31:28]. > + * > + * Note : CPU_3XX_ES20 is used in cache.S. Please review before changing. > */ > #define CPU_3XX_ES10 0 > #define CPU_3XX_ES20 1 > diff --git a/include/asm-arm/arch-omap3/sys_proto.h b/include/asm-arm/arch-omap3/sys_proto.h > index 7361d08..2246f80 100644 > --- a/include/asm-arm/arch-omap3/sys_proto.h > +++ b/include/asm-arm/arch-omap3/sys_proto.h > @@ -55,7 +55,7 @@ void secureworld_exit(void); > void setup_auxcr(void); > void try_unlock_memory(void); > u32 get_boot_type(void); > -void v7_flush_dcache_all(u32); > +void invalidate_dcache(u32); > void sr32(void *, u32, u32, u32); > u32 wait_on_value(u32, u32, void *, u32); > void sdelay(unsigned long); ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix 2009-08-12 16:35 ` Dirk Behme @ 2009-08-12 21:13 ` Jean-Christophe PLAGNIOL-VILLARD 2009-08-12 22:38 ` Tom 2009-08-12 21:49 ` Wolfgang Denk 2009-09-10 23:39 ` Paulraj, Sandeep 3 siblings, 1 reply; 9+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-08-12 21:13 UTC (permalink / raw) To: u-boot On 10:42 Wed 12 Aug , Tom Rix wrote: > v7_flush_dcache_all, because it depends on omap ROM code is not > generic. Rename the function to 'invalidate_dcache' and move it > to the omap cpu directory. > > Collect the other omap cache routines l2_cache_enable and > l2_cache_disable with invalide_dcache into cache.S. This > means removing the old cache.c file that contained l2_cache_enable > and l2_cache_disable. > > The conversion from cache.c to cache.S was done most through > disassembling the uboot binary. The only significant change was > to change the comparision for the return of get_cpu_rev from > > cmp r0, #0 > beq earlier_than_label > > Which was lost information to > > cmp r0, #CPU_3XX_ES20 > blt earlier_than_label > > The paths through the enable routine were verified by > adding an infinite loop and seeing the hang. Then > removing the infinite loop and seeing it continue. > > The disable routine is similar enough that it was not > tested with this method. > > Run tested by cold booting from nand on beagle and zoom1. > Compile tested on MAKEALL arm. for the l2 cache ACK for the invalidate cache NACK we do not need to call the rom code as the armv7 flush cache work fine on omap3 and duplicate armv7 code with really few code (non needed) no Best Regards, J. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 21:13 ` Jean-Christophe PLAGNIOL-VILLARD @ 2009-08-12 22:38 ` Tom 0 siblings, 0 replies; 9+ messages in thread From: Tom @ 2009-08-12 22:38 UTC (permalink / raw) To: u-boot Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:42 Wed 12 Aug , Tom Rix wrote: > >> v7_flush_dcache_all, because it depends on omap ROM code is not >> generic. Rename the function to 'invalidate_dcache' and move it >> to the omap cpu directory. >> >> <snip> > for the l2 cache ACK > for the invalidate cache NACK > > we do not need to call the rom code as the armv7 flush cache work fine > on omap3 and duplicate armv7 code with really few code (non needed) no > > Jean, I disagree on the invalidate cache NAK. First, you were fine with change earlier From an earlier email. flush_dcache was chosen to match other boards/cpu's and one of the > main reasons for this change. If Jean is ok changing flush_dcache > to invalidate_dcache, I will make that change too. invalidate_dcache is fine for me Best Regards, J. Second, removing the invalidate_dcache will change OMAP. This is different from this change which is really just moving code around. As a separate change, it should be submitted as a new change. Without moving invalidate_dcache and the l2_* functions to cache.S, we are so close to where we are now, with l2_* in cache.c that I am not sure what you really want. Tom > Best Regards, > J. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix 2009-08-12 16:35 ` Dirk Behme 2009-08-12 21:13 ` Jean-Christophe PLAGNIOL-VILLARD @ 2009-08-12 21:49 ` Wolfgang Denk 2009-08-12 22:17 ` Tom 2009-09-10 23:39 ` Paulraj, Sandeep 3 siblings, 1 reply; 9+ messages in thread From: Wolfgang Denk @ 2009-08-12 21:49 UTC (permalink / raw) To: u-boot Dear Tom Rix, In message <1250091750-1525-2-git-send-email-Tom.Rix@windriver.com> you wrote: > v7_flush_dcache_all, because it depends on omap ROM code is not > generic. Rename the function to 'invalidate_dcache' and move it > to the omap cpu directory. > > Collect the other omap cache routines l2_cache_enable and > l2_cache_disable with invalide_dcache into cache.S. This > means removing the old cache.c file that contained l2_cache_enable > and l2_cache_disable. > > The conversion from cache.c to cache.S was done most through > disassembling the uboot binary. The only significant change was > to change the comparision for the return of get_cpu_rev from May I ask what the motivation for this change was? Normally we try to move as much code as possible to C, i. e. go the opposite way. > The disable routine is similar enough that it was not > tested with this method. > > Run tested by cold booting from nand on beagle and zoom1. > Compile tested on MAKEALL arm. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Do not underestimate the value of print statements for debugging. Don't have aesthetic convulsions when using them, either. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 21:49 ` Wolfgang Denk @ 2009-08-12 22:17 ` Tom 0 siblings, 0 replies; 9+ messages in thread From: Tom @ 2009-08-12 22:17 UTC (permalink / raw) To: u-boot Wolfgang Denk wrote: > Dear Tom Rix, > > In message <1250091750-1525-2-git-send-email-Tom.Rix@windriver.com> you wrote: > >> v7_flush_dcache_all, because it depends on omap ROM code is not >> generic. Rename the function to 'invalidate_dcache' and move it >> to the omap cpu directory. >> >> Collect the other omap cache routines l2_cache_enable and >> l2_cache_disable with invalide_dcache into cache.S. This >> means removing the old cache.c file that contained l2_cache_enable >> and l2_cache_disable. >> >> The conversion from cache.c to cache.S was done most through >> disassembling the uboot binary. The only significant change was >> to change the comparision for the return of get_cpu_rev from >> > > May I ask what the motivation for this change was? Normally we try to > move as much code as possible to C, i. e. go the opposite way. > > Originally this started out as just a simple patch to kill some compiler warnings. From Jean's requests it grew into moving the invalidate_dcache out of the arm_cortexa8 start.S to an omap3. To collecting the other cache functions all together in a single cache.S file. The part of the patch that killed the compiler warning has, I believe, you have integrated with commit 8e5e9b940cdede0debe528cdd7edccccbb3ebf2a Here are the last emails on this patch On 21:57 Mon 06 Jul , Tom wrote: > > Woodruff, Richard wrote: > >>> > >>From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On >>> > >>Behalf Of Tom Rix >>> > >>Sent: Monday, July 06, 2009 11:48 AM >>> >> > > >> >>> > >>Since there is only one version of flushing the dcache for >>> > >>arm_cortex8, rename v7_flush_dcache_all to the the generic >>> > >>name flush_dcache. Because the function is intended for >>> > >>only omap3 boards, move the function to the new file >>> > >>cache_flush.S. >>> >> > > >> > >Minor point is file name or function name might change to be more reflective of what it does (cache_ops.S, and invalidate_dcache()). As there is not really any 'flush' (cleaning out dirty entries to main memory). >> > > >> > > I will change the name to cache_ops.S > I prefer cache.S > > flush_dcache was chosen to match other boards/cpu's and one of the > > main reasons for this change. If Jean is ok changing flush_dcache > > to invalidate_dcache, I will make that change too. > invalidate_dcache is fine for me Best Regards, J. On 15:44 Tue 07 Jul , Tom wrote: > > Jean-Christophe PLAGNIOL-VILLARD wrote: > >>> > >> >>> > >>I will change the name to cache_ops.S >>> >> > >I prefer cache.S >> > > cache.c is already taken. > and contain nearly only assembly so join everythink in cache.S will make more sense Best Regards, J. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix ` (2 preceding siblings ...) 2009-08-12 21:49 ` Wolfgang Denk @ 2009-09-10 23:39 ` Paulraj, Sandeep 2009-09-11 1:11 ` Tom 3 siblings, 1 reply; 9+ messages in thread From: Paulraj, Sandeep @ 2009-09-10 23:39 UTC (permalink / raw) To: u-boot > v7_flush_dcache_all, because it depends on omap ROM code is not > generic. Rename the function to 'invalidate_dcache' and move it > to the omap cpu directory. > > Collect the other omap cache routines l2_cache_enable and > l2_cache_disable with invalide_dcache into cache.S. This > means removing the old cache.c file that contained l2_cache_enable > and l2_cache_disable. > > The conversion from cache.c to cache.S was done most through > disassembling the uboot binary. The only significant change was > to change the comparision for the return of get_cpu_rev from > > cmp r0, #0 > beq earlier_than_label > > Which was lost information to > > cmp r0, #CPU_3XX_ES20 > blt earlier_than_label > > The paths through the enable routine were verified by > adding an infinite loop and seeing the hang. Then > removing the infinite loop and seeing it continue. > > The disable routine is similar enough that it was not > tested with this method. > > Run tested by cold booting from nand on beagle and zoom1. > Compile tested on MAKEALL arm. > > Signed-off-by: Tom Rix <Tom.Rix@windriver.com> > --- > cpu/arm_cortexa8/cpu.c | 2 +- > cpu/arm_cortexa8/omap3/Makefile | 2 +- > cpu/arm_cortexa8/omap3/board.c | 2 +- > cpu/arm_cortexa8/omap3/cache.S | 191 > ++++++++++++++++++++++++++++++++ > cpu/arm_cortexa8/omap3/cache.c | 95 ---------------- > cpu/arm_cortexa8/start.S | 85 -------------- > include/asm-arm/arch-omap3/omap3.h | 2 + > include/asm-arm/arch-omap3/sys_proto.h | 2 +- > 8 files changed, 197 insertions(+), 184 deletions(-) > create mode 100644 cpu/arm_cortexa8/omap3/cache.S > delete mode 100644 cpu/arm_cortexa8/omap3/cache.c Applied to u-boot-ti -Sandeep ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S 2009-09-10 23:39 ` Paulraj, Sandeep @ 2009-09-11 1:11 ` Tom 0 siblings, 0 replies; 9+ messages in thread From: Tom @ 2009-09-11 1:11 UTC (permalink / raw) To: u-boot Paulraj, Sandeep wrote: >> v7_flush_dcache_all, because it depends on omap ROM code is not >> generic. Rename the function to 'invalidate_dcache' and move it >> to the omap cpu directory. >> >> Collect the other omap cache routines l2_cache_enable and >> l2_cache_disable with invalide_dcache into cache.S. This >> means removing the old cache.c file that contained l2_cache_enable >> and l2_cache_disable. >> >> The conversion from cache.c to cache.S was done most through >> disassembling the uboot binary. The only significant change was >> to change the comparision for the return of get_cpu_rev from >> >> cmp r0, #0 >> beq earlier_than_label >> >> Which was lost information to >> >> cmp r0, #CPU_3XX_ES20 >> blt earlier_than_label >> >> The paths through the enable routine were verified by >> adding an infinite loop and seeing the hang. Then >> removing the infinite loop and seeing it continue. >> >> The disable routine is similar enough that it was not >> tested with this method. >> >> Run tested by cold booting from nand on beagle and zoom1. >> Compile tested on MAKEALL arm. >> >> Signed-off-by: Tom Rix <Tom.Rix@windriver.com> >> --- >> cpu/arm_cortexa8/cpu.c | 2 +- >> cpu/arm_cortexa8/omap3/Makefile | 2 +- >> cpu/arm_cortexa8/omap3/board.c | 2 +- >> cpu/arm_cortexa8/omap3/cache.S | 191 >> ++++++++++++++++++++++++++++++++ >> cpu/arm_cortexa8/omap3/cache.c | 95 ---------------- >> cpu/arm_cortexa8/start.S | 85 -------------- >> include/asm-arm/arch-omap3/omap3.h | 2 + >> include/asm-arm/arch-omap3/sys_proto.h | 2 +- >> 8 files changed, 197 insertions(+), 184 deletions(-) >> create mode 100644 cpu/arm_cortexa8/omap3/cache.S >> delete mode 100644 cpu/arm_cortexa8/omap3/cache.c > > Applied to u-boot-ti > > -Sandeep Thanks! I am traveling tomorrow and I will pull it this weekend. Tom ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-09-11 1:11 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-08-12 15:42 [U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix 2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix 2009-08-12 16:35 ` Dirk Behme 2009-08-12 21:13 ` Jean-Christophe PLAGNIOL-VILLARD 2009-08-12 22:38 ` Tom 2009-08-12 21:49 ` Wolfgang Denk 2009-08-12 22:17 ` Tom 2009-09-10 23:39 ` Paulraj, Sandeep 2009-09-11 1:11 ` Tom
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox