[U-Boot] [PATCH] OMAP3 Move cache routines to cache.S

Wolfgang Denk
2009-08-12T21:49:41Z

Dear Tom Rix,

In message <1250091750-1525-2-git-send-email-Tom.Rix@windriver.com> you wrote:
> v7_flush_dcache_all, because it depends on omap ROM code is not
> generic. Rename the function to 'invalidate_dcache' and move it
> to the omap cpu directory.
>
> Collect the other omap cache routines l2_cache_enable and
> l2_cache_disable with invalide_dcache into cache.S. This
> means removing the old cache.c file that contained l2_cache_enable
> and l2_cache_disable.
>
> The conversion from cache.c to cache.S was done most through
> disassembling the uboot binary. The only significant change was
> to change the comparision for the return of get_cpu_rev from

May I ask what the motivation for this change was? Normally we try to
move as much code as possible to C, i. e. go the opposite way.

> The disable routine is similar enough that it was not
> tested with this method.
>
> Run tested by cold booting from nand on beagle and zoom1.
> Compile tested on MAKEALL arm.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not underestimate the value of print statements for debugging.
Don't have aesthetic convulsions when using them, either.