From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Wed, 12 Aug 2009 17:38:51 -0500
Subject: [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
In-Reply-To: <20090812211316.GF21725@game.jcrosoft.org>
References: <1250091750-1525-1-git-send-email-Tom.Rix@windriver.com>
	<1250091750-1525-2-git-send-email-Tom.Rix@windriver.com>
	<20090812211316.GF21725@game.jcrosoft.org>
Message-ID: <4A83447B.3010304@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:42 Wed 12 Aug     , Tom Rix wrote:
>   
>> v7_flush_dcache_all, because it depends on omap ROM code is not
>> generic.  Rename the function to 'invalidate_dcache' and move it
>> to the omap cpu directory.
>>
>>     
<snip>

> for the l2 cache ACK
> for the invalidate cache NACK
>
> we do not need to call the rom code as the armv7 flush cache work fine
> on omap3 and duplicate armv7 code with really few code (non needed) no
>
>   
Jean,

I disagree on the invalidate cache NAK.

First, you were fine with change earlier
 From an earlier email.

flush_dcache was chosen to match other boards/cpu's and one of the
> main reasons for this change.  If Jean is ok changing flush_dcache
> to invalidate_dcache,  I will make that change too.

invalidate_dcache is fine for me

Best Regards,
J.


Second, removing the invalidate_dcache will change OMAP.
This is different from this change which is really just moving code around.
As a separate change, it should be submitted as a new change.

Without moving invalidate_dcache and the l2_* functions to cache.S,
we are so close to where we are now, with l2_* in cache.c that I am
not sure what you really want.

Tom
> Best Regards,
> J.
>