From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Mon, 17 Aug 2009 17:21:21 +0200
Subject: [U-Boot] [PATCH] Adding support for DevKit8000
In-Reply-To: <1250500736-20034-1-git-send-email-frederik@kriewitz.eu>
References: <1250500736-20034-1-git-send-email-frederik@kriewitz.eu>
Message-ID: <4A897571.9090404@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Frederik Kriewitz wrote:
> This patch adds support for the DevKit8000 board.

Wolfgang commented already most of the topics.

So, only one comment left for me:

...
> +++ b/board/omap3/devkit8000/devkit8000.c
...
> +/*
> + * Routine: misc_init_r
> + * Description: Configure board specific parts
> + */
> +int misc_init_r(void)
> +{
...
> +	/* Use OMAP DIE_ID as MAC address */
> +	if (!eth_getenv_enetaddr("ethaddr", enetaddr)) {
> +		enetaddr[0] = 0x02; /* locally administered */
> +		enetaddr[1] = readl(&id_base->die_id_1) & 0xff;
> +		*(u32*)&enetaddr[2] = readl(&id_base->die_id_0);
> +		eth_setenv_enetaddr("ethaddr", enetaddr);
> +	}

With the OMAP DIE_ID thread we know what you are doing here. But do we 
want to have this really in mainline? It looks to me like a workaround 
for broken hardware (that is, having no proper MAC address 
configured)? Or do I miss anything?

Best regards

Dirk