[U-Boot] [PATCH] Adding support for DevKit8000

Frederik Kriewitz
2009-08-17T13:45:10Z

Thank you for reviewing my patch.

I've fixed the issues and will submit it again once Jean-Christophe
updated the mach-types.h.

On Mon, Aug 17, 2009 at 11:50 AM, Wolfgang Denk<wd@denx.de> wrote:
>> +#define CONFIG_SYS_MAX_FLASH_SECT ? ?520 ? ? /* max number of sectors on */
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? /* one chip */
>> +#define CONFIG_SYS_MAX_FLASH_BANKS ? 2 ? ? ? /* max number of flash banks */
>> +#define CONFIG_SYS_MONITOR_LEN ? ? ? ? ? ? ? SZ_256K /* Reserve 2 sectors */
>> +
>> +#define CONFIG_SYS_FLASH_BASE ? ? ? ? ? ? ? ?boot_flash_base
>> +
>> +/* Monitor at start of flash */
>> +#define CONFIG_SYS_MONITOR_BASE ? ? ? ? ? ? ?CONFIG_SYS_FLASH_BASE
>
> You seem to have NOR flash, but define NO_FLSH eralier. Is this
> intentional? What is the rationale behind that?

I don't have NOR flash, just NAND. So NO_FLASH is fine.

I'm was confused about the FLASH stuff too.
Other OMAP3 Boards have them too and AFAIK none of them has NOR flash.
e.g. CONFIG_SYS_ENV_SECT_SIZE is defined in several configs but never used.
I removed them and everything works fine.