From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Wed, 19 Aug 2009 12:29:12 -0700
Subject: [U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on
 kirkwood network init
In-Reply-To: <20090819192510.BD75D833DBD2@gemini.denx.de>
References: <20090819122415.0487b2d8@marrow.netinsight.se>
	<4A8C3172.70001@gmail.com>
	<20090819192510.BD75D833DBD2@gemini.denx.de>
Message-ID: <4A8C5288.5020308@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Ben Warren,
>
>   
<snip>
>
>>> +	/* Wait up to 5s for the link status */
>>> +	for (i = 0; i < 5; i++) {
>>> +		u16 phyadr;
>>>   
>>>       
>> Please put this variable declaration outside of the 'for' loop
>>     
>
> Why? If it's only used in this block it's actually a good thing to
> restrict it to this scope.
>
>   
It seems your coding standards have changed, which everybody knows is 
impossible.  Where's you put the old Wolfgang, doppleganger? :)
> Best regards,
>
> Wolfgang Denk
>
>   
regards,
Ben