From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Thu, 20 Aug 2009 10:36:21 -0700
Subject: [U-Boot] [PATCH 1/1 v2][Net] Convert CS8900 Ethernet driver to
 CONFIG_NET_MULTI API
In-Reply-To: <20090820095659.36072833DBD2@gemini.denx.de>
References: <1250145251-23438-1-git-send-email-biggerbadderben@gmail.com>
	<20090813080738.22A42833DBD2@gemini.denx.de>
	<f8328f7c0908132336k18e260d4xac724695594045f0@mail.gmail.com>
	<20090820095659.36072833DBD2@gemini.denx.de>
Message-ID: <4A8D8995.6090700@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Ben Warren,
>
> In message <f8328f7c0908132336k18e260d4xac724695594045f0@mail.gmail.com> you wrote:
>   
>> I looked at a disassembly of this code and it looked like it should work.
>>  In this case, the base offset of the device is in r2 (0x07000300) and the
>> code does store operations on this +#4 and +#6, which were the offsets in
>> the original.  I guess it would be useful to printf something like:
>>
>> printf("addr = %#08x\n", &priv->regs->txcmd) just to make sure it's
>> 0x07000304.
>>
>> Other than that, I'm stumped.  I'll review the code again to see if anything
>> jumps out.
>>     
>
> Hm... adding this patch:
>
> diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c
> index 5b9c4cb..0f86c39 100644
> --- a/drivers/net/cs8900.c
> +++ b/drivers/net/cs8900.c
> @@ -215,6 +215,11 @@ static int cs8900_send(struct eth_device *dev,
>  	struct cs8900_priv *priv = (struct cs8900_priv *)(dev->priv);
>  
>  retry:
> +	printf("priv=%#08x  regs=%#08x  txcmd=%#08x\n",
> +		(unsigned int)priv,
> +		(unsigned int)(priv->regs),
> +		(unsigned int)(&priv->regs->txcmd));
> +		
>  	/* initiate a transmit sequence */
>  	writel(PP_TxCmd_TxStart_Full, &priv->regs->txcmd);
>  	writel(length, &priv->regs->txlen);
>
> And testing on the mx31ads board I get this:
>
> => run load
> Using CS8900-0 device
> TFTP from server 192.168.1.1; our IP address is 192.168.20.9
> Filename 'mx31ads/u-boot.bin'.
> Load address: 0x80800000
> Loading: priv=0x87ed8100  regs=0xb4020300  txcmd=0xb4020304
> <hangs>
>
>   
Well, the addresses look correct to me:

Definitions for this board prior to my patch:

#define CS8900_REG u16
#define CS8900_BASE 0xb4020300
#define CS8900_OFF 0x02
...  

#define CS8900_TxCMD  *(volatile CS8900_REG *)(CS8900_BASE+0x02*CS8900_OFF)
#define CS8900_TxLEN  *(volatile CS8900_REG *)(CS8900_BASE+0x03*CS8900_OFF)

Shit!  The accessor should be writew(), not writel().
That could very well be why this isn't working.  I'll put together another patch.


> Best regards,
>
> Wolfgang Denk
>
>   
Thanks a lot for your help.

Ben