From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
Date: Tue, 25 Aug 2009 09:40:02 -0700 [thread overview]
Message-ID: <4A9413E2.9070103@gmail.com> (raw)
In-Reply-To: <20090825105358.315F9833DBD2@gemini.denx.de>
Wolfgang,
Wolfgang Denk wrote:
> Dear Ben Warren,
>
> In message <4A9069E9.2030000@gmail.com> you wrote:
>
>>> Tested on mx31ads: works like a charm.
>>>
>>>
>> Great news! Thanks!
>>
>>> Will try to debug the trab issues later tonight (if I manage to find a
>>> matching JTAG connector for this board ).
>>>
>
> OK, tested on trab (= SMDK2400), too. [The observed problems were
> caused by other, unrelated issues.]
>
>
Great!
> You might want to consider adding this patch, though:
>
> From e1236c57d747c4b686f9918dba2333d4df539a54 Mon Sep 17 00:00:00 2001
> From: Wolfgang Denk <wd@denx.de>
> Date: Tue, 25 Aug 2009 11:55:16 +0200
> Subject: [PATCH] cs8900.c: Fix implicit integer to pointer conversion
>
> ---
> drivers/net/cs8900.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c
> index b5555fe..587f7f6 100644
> --- a/drivers/net/cs8900.c
> +++ b/drivers/net/cs8900.c
> @@ -68,12 +68,13 @@ static u16 get_reg_init_bus(struct eth_device *dev, int regno)
> /* force 16 bit busmode */
> volatile u8 c;
> struct cs8900_priv *priv = (struct cs8900_priv *)(dev->priv);
> + uint8_t volatile * const iob = (uint8_t volatile * const)dev->iobase;
>
> - c = readb(dev->iobase);
> - c = readb(dev->iobase + 1);
> - c = readb(dev->iobase);
> - c = readb(dev->iobase + 1);
> - c = readb(dev->iobase);
> + c = readb(iob);
> + c = readb(iob + 1);
> + c = readb(iob);
> + c = readb(iob + 1);
> + c = readb(iob);
>
> REG_WRITE(regno, &priv->regs->pptr);
> return REG_READ(&priv->regs->pdata);
>
I'll add this and put this in the net/next branch. Thanks for the help!
regards,
Ben
prev parent reply other threads:[~2009-08-25 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 2:46 [U-Boot] [PATCH v3][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API Ben Warren
2009-08-22 12:23 ` Wolfgang Denk
2009-08-22 13:20 ` Wolfgang Denk
2009-08-22 21:58 ` Ben Warren
2009-08-24 20:44 ` Wolfgang Denk
2009-08-25 10:53 ` Wolfgang Denk
2009-08-25 16:40 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9413E2.9070103@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox