public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] mpc83xx: update LCRR register handling
Date: Thu, 27 Aug 2009 07:41:46 -0400	[thread overview]
Message-ID: <4A9670FA.4030108@gmail.com> (raw)
In-Reply-To: <4A9625B3.7040509@denx.de>

Hi Heiko,

One minor critique, I had problems parsing the comment:

Heiko Schocher wrote:
> MPC8379E RM says (10-34):
> Once LCRR[CLKDIV] is written, the register should be read, and then
> an isync should be executed.
> So update this in code.
> Also define a LCRR mask for processors, which uses not all bits
                                           ^^^^^^^^^^^^^^^^^^^^^^^
Suggested change:
Also define a LCRR mask for processors to prevent setting any reserved 
bits in the LCRR register (as, for example, mpc832x did).

> in the LCRR register (as for example mpc832x did).
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>

Thanks,
gvb

  reply	other threads:[~2009-08-27 11:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-25  9:05 [U-Boot] mpc83xx: update LCRR register handling Heiko Schocher
2009-08-25  9:14 ` Liu Dave-R63238
2009-08-25 11:31   ` [U-Boot] [PATCH v2] " Heiko Schocher
2009-08-25 12:19     ` Liu Dave-R63238
2009-08-25 15:39     ` Kim Phillips
2009-08-26  6:28       ` Heiko Schocher
2009-08-26 22:36         ` Kim Phillips
2009-08-27  6:20           ` [U-Boot] [PATCH v3] " Heiko Schocher
2009-08-27 11:41             ` Jerry Van Baren [this message]
2009-08-27 20:53             ` Kim Phillips
2009-09-16  4:51               ` Kumar Gala
2009-09-25 23:19                 ` [U-Boot] [PATCH] mpc83xx: retain POR values of non-configured ACR, SPCR, SCCR, and LCRR bitfields (was: Re: [PATCH v3] mpc83xx: update LCRR register handling) Kim Phillips
2009-09-26 10:37                   ` [U-Boot] [PATCH] mpc83xx: retain POR values of non-configured ACR, SPCR, SCCR, and LCRR bitfields Heiko Schocher
2009-09-27  1:46                     ` Kim Phillips
2009-09-27  1:54                       ` Kim Phillips
2009-08-27 11:11           ` [U-Boot] [PATCH v2] mpc83xx: update LCRR register handling Detlev Zundel
2009-08-27 20:49             ` Kim Phillips
2009-08-28 10:36               ` Detlev Zundel
2009-08-28 12:02                 ` Wolfgang Denk
2009-08-28 16:01                   ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9670FA.4030108@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox