From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Thu, 27 Aug 2009 14:16:21 -0500 Subject: [U-Boot] [RFC PATCH 2/3] net: add phylib implementation In-Reply-To: <200908271513.47636.vapier@gentoo.org> References: <4A938C76.9000009@monstr.eu> <200908270154.47824.vapier@gentoo.org> <20090827153807.GA4581@b07421-ec1.am.freescale.net> <200908271513.47636.vapier@gentoo.org> Message-ID: <4A96DB85.1090904@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > On Thursday 27 August 2009 11:38:07 Scott Wood wrote: >> On Thu, Aug 27, 2009 at 01:54:47AM -0400, Mike Frysinger wrote: >>> On Thursday 27 August 2009 01:11:32 Stefan Roese wrote: >>>> On Thursday 27 August 2009 03:55:57 Mike Frysinger wrote: >>>>>> +int phy_init(void) >>>>>> +{ >>>>>> + /* Initialize the list */ >>>>>> + INIT_LIST_HEAD(&phy_drvs.list); >>>>> does it really need to be dynamic ? arent there static initializers >>>>> so this can be done in .data ? >>>> Using static initializers fails on PPC because of the somewhat broken >>>> relocation. So this dynamic implementation is the preferred version, at >>>> least for PPC people. >>> so the ppc port cant use the .data section at all ? that doesnt sound >>> correct to me. >> We can't have initialized pointers in .data without manual runtime fixup. >> Only .text has relocation information. > > we're talking about a list structure and its initialized state, it isnt > pointing to anything. It's pointing to itself. -Scott