From: "Kári Davíðsson" <kari.davidsson@marel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] invalid core multipliers?
Date: Tue, 1 Sep 2009 17:59:38 +0000 [thread overview]
Message-ID: <4A9D610A.3020206@marel.com> (raw)
In-Reply-To: <20090901173814.GA4471@oksana.dev.rtsoft.ru>
Hello,
I am bootstrapping an mpc5121e board.
When the cpu speed is calculated (cpu/mpc512x/speed.c) there is a comment about
all core pll settings above 7 are invalid....
I can't see anything about that in the CPU documentation so I am wondering if
anyone has reference to where this is defined as invalid.
The board I am using is using CORE PLL index 0x8, i.e. multiplier of 4.
If this comment in the code is wrong then the following patch should be o.k...
Index: cpu/mpc512x/speed.c
===================================================================
--- cpu/mpc512x/speed.c (revision 635)
+++ cpu/mpc512x/speed.c (working copy)
@@ -44,7 +44,7 @@
{1, 1}, {3, 2},
{2, 1}, {5, 2},
{3, 1}, {7, 2},
- {0, 1}, {0, 1}, /* and all above 7 are not valid too */
+ {4, 1}, {0, 1}, /* and all above 7 are not valid too.... I doubt this claim */
{0, 1}, {0, 1},
{0, 1}, {0, 1},
{0, 1}, {0, 1}
rg
kd
next prev parent reply other threads:[~2009-09-01 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 16:59 [U-Boot] [PATCH 2/2] fsl: sys_eeprom: Fix 'may be used uninitialized' warning Anton Vorontsov
2009-09-01 17:30 ` Kumar Gala
2009-09-01 17:38 ` Anton Vorontsov
2009-09-01 17:59 ` Kári Davíðsson [this message]
2009-09-04 20:57 ` [U-Boot] invalid core multipliers? Wolfgang Denk
2009-09-01 18:06 ` [U-Boot] [PATCH 2/2] fsl: sys_eeprom: Fix 'may be used uninitialized' warning Anton Vorontsov
2009-09-01 18:09 ` Timur Tabi
2009-09-01 18:27 ` [U-Boot] [PATCH 2/2] fsl: sys_eeprom: Fix 'may be used uninitialized' warningп Anton Vorontsov
2009-09-01 19:22 ` [U-Boot] [PATCH 2/2] fsl: sys_eeprom: Fix 'may be used uninitialized' warning Wolfgang Denk
2009-09-01 18:16 ` Wolfgang Denk
2009-09-01 18:29 ` Anton Vorontsov
2009-09-01 19:42 ` Wolfgang Denk
2009-09-01 18:38 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9D610A.3020206@marel.com \
--to=kari.davidsson@marel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox