From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Tue, 01 Sep 2009 15:06:11 -0500
Subject: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode
	NAND_ECC_HW_OOB_FIRST
In-Reply-To: <200909011359.52037.mwaddel@control4.com>
References: <7081825318460577925@unknownmsgid>
	<0554BEF07D437848AF01B9C9B5F0BC5D9217B2F9@dlee01.ent.ti.com>
	<4A9D73AD.6060506@freescale.com>
	<200909011359.52037.mwaddel@control4.com>
Message-ID: <4A9D7EB3.9090100@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Matt Waddel wrote:
> Hi Scott and Sandeep,
> 
> As long as we're looking at these patches again I had a question about 
> patch 1 of 2 in this series.  
> 
> The following part of the patch added a definition for: 
> 
> chip->ecc.read_page = nand_read_page_hwecc_oob_first
> 
> but since there aren't any "break" statements until "case NAND_ECC_SOFT:" 
> it looks like the chip->ecc.read_page definition ends up being set to:
> 
> chip->ecc.read_page = nand_read_page_swecc.
> 
> Maybe this is explains why things seem to be working???

No, that's OK -- it stops before that on the
"if (mtd->writesize >= chip->ecc.size) break;" line (or if that 
condition is not true, it prints a warning that it is falling back on 
soft ecc).

-Scott