[U-Boot] [PATCH] Add support for the DevKit8000 board

Wolfgang Denk
2009-08-23T19:15:37Z

Dear Frederik Kriewitz,

In message <1251048253-14273-1-git-send-email-frederik@kriewitz.eu> you wrote:
> This patch adds support for the DevKit8000 board.
>
> Signed-off-by: Frederik Kriewitz <frederik@kriewitz.eu>
> ---
> mach-types.h needs to be synced (MACH_TYPE_DEVKIT8000)
> ---
> ---
> MAINTAINERS | 4 +
> MAKEALL | 1 +
...

Will you please try and follow the rules?

I don't see any indication that this is a repost of earlier patches. I
would expoect a version number (something like "[PATCH v4]") in the
subject line.

git patches have exactly one "---" line, not 3.

I would expect to find a comment what you changed in this version of
the patch compared to older versions. Or do you expect us to invest
lots of (avoidable) effort to compare the diffs?

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anyone who isn't confused here doesn't really know what's going on.