From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Sun, 06 Sep 2009 11:09:54 +0200 Subject: [U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable In-Reply-To: <1252099715-19255-1-git-send-email-timur@freescale.com> References: <1252099715-19255-1-git-send-email-timur@freescale.com> Message-ID: <4AA37C62.5090504@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Timur, Timur Tabi wrote: > The value of I2C_TIMEOUT in fsl_i2c.c has several problems. First, it is > defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes > no sense to derive it from a clock rate. Second, the current value (250) is > too low for some boards, so it needs to be increased. Third, the timeout > necessary for multiple-master arbitration is larger than the timeout for basic > read/write operations, so we shouldn't have a single constant for both timeouts. > Finally, it would be nice if we could override these values on a per-board > basis. > > Signed-off-by: Timur Tabi > --- > drivers/i2c/fsl_i2c.c | 24 ++++++++++++++++++++---- > 1 files changed, 20 insertions(+), 4 deletions(-) Applied to u-boot-i2c.git Thanks for your work, bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany