[U-Boot] [PATCH 4/8] OMAP3 Add usb device support

Jean-Christophe PLAGNIOL-VILLARD
2009-09-06T13:48:39Z

> >>+ }
> >>+
> >>+ if (debug_setup && (debug_level > 1))
> >>+ musb_db_regs();
> >>+}
> >>+
> >>+static void musb_peri_reset(void)
> >>+{
> >>+ if ((debug_setup) && (debug_level > 1))
> >>+ serial_printf("INFO : %s reset\n", __PRETTY_FUNCTION__);
> >what do you mean y __PRETTY_FUNCTION__?
> This a gcc compiler macro for printing out the function of the calling
> routine. It is useful in the macro's like the state machine changer
> to show which function did the change instead of the usual
> __LINE__ + __FILE__ + eyeball time. It is a non-standard cpp macro
> and would bite us when compiling without gcc. Does u-boot build
> with non-gcc ?
no only gcc but I think it will not be impossible to use an other toolchains
but ok
> >>+
> >>+ /* the device address is reset by the event */
> >>diff --git a/include/usb.h b/include/usb.h
> >>index 378a23b..198d5bb 100644
> >>--- a/include/usb.h
> >>+++ b/include/usb.h
> >>@@ -131,7 +131,8 @@ struct usb_device {
> >> #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \
> >> defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \
> >> defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \
> >>- defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI)
> >>+ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \
> >>+ defined(CONFIG_USB_OMAP3)
> >a simple CONFIG will be better
> Can this be a follow-on ?
ofcource

Best Regards,
J.