From mboxrd@z Thu Jan 1 00:00:00 1970 From: kevin.morfitt at fearnside-systems.co.uk Date: Mon, 07 Sep 2009 23:05:32 +0100 Subject: [U-Boot] [PATCH-ARM] CONFIG_SYS_HZ fix for ARM902T S3C24X0 Boards In-Reply-To: <20090907214701.47D21832E8DE@gemini.denx.de> References: <4AA284B9.8030009@fearnside-systems.co.uk> <20090907214701.47D21832E8DE@gemini.denx.de> Message-ID: <4AA583AC.3050401@fearnside-systems.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/09/2009 22:47, Wolfgang Denk wrote: > Dear "kevin.morfitt at fearnside-systems.co.uk", > > In message <4AA284B9.8030009@fearnside-systems.co.uk> you wrote: >> This sets CONFIG_SYS_HZ to 1000 for all boards that use the s3c2400 and >> s3c2410 cpu's which fixes various problems such as the timeouts in tftp being >> too short. > > I still wonder if this is really an issue. Some s3c2400 based boards > have been in production use for several years, with volumes of many > thousands of devices per year. Yet no TFTP timeout issues have been > reported ever. > >> This affects the sbc2410, smdk2400, smdk2410 and trab boards. I've copied it >> directly to the maintainers of all except the sbc2410 which doesn't have an >> entry in MAINTAINERS. > > I tested it on trab, and I don't see any changes - both U-Boot and > Linux still work as they always used to work. > > Tested-by: Wolfgang Denk > > Best regards, > > Wolfgang Denk > I think there were no problems because CONFIG_SYS_HZ was set to values that worked for each of the s3c24x0 boards. I only submitted the patch because my first attempt at a patch for the Embest SBC2440-II was NAK-ed because I'd set CONFIG_SYS_HZ to the original sbc2410x setting of 1562500 (which worked) - there was a global change going through to set CONFIG_SYS_HZ to 1000 for all boards though I'm not sure what the reason was. I'm happy to withdraw the patch if it's OK to set CONFIG_SYS_HZ to a different value than 1000? __________ Information from ESET NOD32 Antivirus, version of virus signature database 4403 (20090907) __________ The message was checked by ESET NOD32 Antivirus. http://www.eset.com